Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7527)

Unified Diff: chrome/browser/ui/webui/options/chromeos/system_options_handler.cc

Issue 7867044: PART1: Initiated the SignedSettings refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and issues. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/system_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/system_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/system_options_handler.cc
index 4f343f9bd24f434dfbe4e46067bef984d837cd12..ef0a627e869e12662296f56185abbca77efafd08 100644
--- a/chrome/browser/ui/webui/options/chromeos/system_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/system_options_handler.cc
@@ -15,6 +15,7 @@
#include "content/common/json_value_serializer.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chromeos/accessibility_util.h"
+#include "chrome/browser/chromeos/cros_settings.h"
#include "chrome/browser/chromeos/language_preferences.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/prefs/pref_service.h"
@@ -30,9 +31,7 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
-SystemOptionsHandler::SystemOptionsHandler()
- : chromeos::CrosOptionsPageUIHandler(
- new chromeos::SystemSettingsProvider()) {
+SystemOptionsHandler::SystemOptionsHandler() {
}
SystemOptionsHandler::~SystemOptionsHandler() {
@@ -80,9 +79,12 @@ void SystemOptionsHandler::GetLocalizedValues(
l10n_util::GetStringUTF16(
IDS_OPTIONS_SETTINGS_ACCESSIBILITY_DESCRIPTION));
+ // TODO(pastarmovj): replace this with a call to the CrosSettings list
+ // handling functionality to come.
Mattias Nissler (ping if slow) 2011/09/26 17:26:37 haven't you included that list handling already no
pastarmovj 2011/09/29 15:15:03 I'd rather fix this in a separate CL.
localized_strings->Set("timezoneList",
- reinterpret_cast<chromeos::SystemSettingsProvider*>(
- settings_provider_.get())->GetTimezoneList());
+ static_cast<chromeos::SystemSettingsProvider*>(
+ chromeos::CrosSettings::Get()->GetProvider(
+ chromeos::kSystemTimezone))->GetTimezoneList());
}
void SystemOptionsHandler::Initialize() {

Powered by Google App Engine
This is Rietveld 408576698