PART1: Initiated the SignedSettings refactoring.

chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/hash_tables.h"
 #include "base/logging.h"
 #include "base/task.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
+#include "chrome/browser/chromeos/cros_settings.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/network_library.h"
 #include "chrome/browser/chromeos/dbus/dbus_thread_manager.h"
 #include "chrome/browser/chromeos/dbus/power_manager_client.h"
 #include "chrome/browser/chromeos/input_method/input_method_manager.h"
 #include "chrome/browser/chromeos/input_method/xkeyboard.h"
 #include "chrome/browser/chromeos/login/screen_locker.h"
 #include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/chromeos/login/webui_login_display.h"
-#include "chrome/browser/chromeos/user_cros_settings_provider.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/net/gaia/gaia_urls.h"
 #include "chrome/common/url_constants.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
@@ skipping 428 matching lines @@
 
 void SigninScreenHandler::LoadAuthExtension(bool force, bool silent_load) {
   DictionaryValue params;
 
   params.SetBoolean("forceReload", force);
   params.SetBoolean("silentLoad", silent_load);
   params.SetString("startUrl", kGaiaExtStartPage);
   params.SetString("email", email_);
   email_.clear();
 
-  params.SetBoolean("createAccount",
-      UserCrosSettingsProvider::cached_allow_new_user());
-  params.SetBoolean("guestSignin",
-      UserCrosSettingsProvider::cached_allow_guest());
+  // TODO(pastarmovj): Observe for changes of this variables to update the UI

[Mattias Nissler (ping if slow), 2011/11/18 14:12:00]

"Watch for" or "Observe". I have never heard of "observer for" in this context
though... ;)

[pastarmovj, 2011/11/18 15:01:38]

Done.

+  // properly when the policy has been fetched on sign-on screen.
+  bool allow_new_user;

[Mattias Nissler (ping if slow), 2011/11/18 14:12:00]

Properly initialize these variables (also below) if you choose to intentionally
ignore the GetBoolean return value.

[pastarmovj, 2011/11/18 15:01:38]

done.

+  CrosSettings::Get()->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
+  params.SetBoolean("createAccount", allow_new_user);
+  bool allow_guest;
+  CrosSettings::Get()->GetBoolean(kAccountsPrefAllowGuest, &allow_guest);
+  params.SetBoolean("guestSignin", allow_guest);
 
   const std::string app_locale = g_browser_process->GetApplicationLocale();
   if (!app_locale.empty())
     params.SetString("hl", app_locale);
 
   params.SetString("gaiaOrigin", GaiaUrls::GetInstance()->gaia_origin_url());
 
   // Test automation data:
   const CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kAuthExtensionPath)) {
@@ skipping 107 matching lines @@
 
   size_t max_non_owner_users = show_guest ? kMaxUsers - 2 : kMaxUsers - 1;
   size_t non_owner_count = 0;
 
   ListValue users_list;
   const UserList& users = delegate_->GetUsers();
 
   bool single_user = users.size() == 1;
   for (UserList::const_iterator it = users.begin(); it != users.end(); ++it) {
     const std::string& email = (*it)->email();
-    bool is_owner = email == UserCrosSettingsProvider::cached_owner();
+    std::string owner;
+    chromeos::CrosSettings::Get()->GetString(chromeos::kDeviceOwner, &owner);
+    bool is_owner = (email == owner);
     bool signed_in = UserManager::Get()->user_is_logged_in() &&
         email == UserManager::Get()->logged_in_user().email();
 
     if (non_owner_count < max_non_owner_users || is_owner) {
       DictionaryValue* user_dict = new DictionaryValue();
       user_dict->SetString(kKeyName, (*it)->GetDisplayName());
       user_dict->SetString(kKeyEmailAddress, email);
       user_dict->SetInteger(kKeyOauthTokenStatus, (*it)->oauth_token_status());
       user_dict->SetBoolean(kKeySignedIn, signed_in);
 
@@ skipping 109 matching lines @@
 
   cookie_remover_ = new BrowsingDataRemover(
       Profile::FromBrowserContext(web_ui_->tab_contents()->browser_context()),
       BrowsingDataRemover::EVERYTHING,
       base::Time());
   cookie_remover_->AddObserver(this);
   cookie_remover_->Remove(BrowsingDataRemover::REMOVE_SITE_DATA);
 }
 
 }  // namespace chromeos