PART1: Initiated the SignedSettings refactoring.

chrome/browser/chromeos/user_cros_settings_provider.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_USER_CROS_SETTINGS_PROVIDER_H_
 #define CHROME_BROWSER_CHROMEOS_USER_CROS_SETTINGS_PROVIDER_H_
 #pragma once
 
 #include <string>
 
@@ skipping 14 matching lines @@
 // TODO(nkostylev): Rename this class to indicate that it is
 // SignedSettings specific.
 class UserCrosSettingsProvider : public CrosSettingsProvider {
  public:
   UserCrosSettingsProvider();
   virtual ~UserCrosSettingsProvider() {}
 
   // Registers cached users settings in preferences.
   static void RegisterPrefs(PrefService* local_state);
 
-  // Methods to use when trusted (signature verified) values are required.
-  // Return true if subsequent call to corresponding cached_* getter shall
-  // return trusted value.
-  // Return false if trusted values are unavailable at a moment.
-  // In latter case passed task will be posted when ready.
-  bool RequestTrustedAllowGuest(Task* callback);
-  bool RequestTrustedAllowNewUser(Task* callback);
-  bool RequestTrustedDataRoamingEnabled(Task* callback);
-  bool RequestTrustedShowUsersOnSignin(Task* callback);
-  bool RequestTrustedOwner(Task* callback);
-  bool RequestTrustedReportingEnabled(Task* callback);
-
   // Reloads values from device settings.
   void Reload();
 
-  // Helper functions to access cached settings.
-  static bool cached_allow_guest();
-  static bool cached_allow_new_user();
-  static bool cached_data_roaming_enabled();
-  static bool cached_show_users_on_signin();
-  static bool cached_reporting_enabled();
-  static const base::ListValue* cached_whitelist();
-  static std::string cached_owner();
-
-  // Returns true if given email is in user whitelist.
-  // Note this function is for display purpose only and should use
-  // CheckWhitelist op for the real whitelist check.
-  static bool IsEmailInCachedWhitelist(const std::string& email);
-
   // CrosSettingsProvider implementation.
-  virtual bool Get(const std::string& path,
-                   base::Value** out_value) const OVERRIDE;
+  virtual const base::Value* Get(const std::string& path) const OVERRIDE;
+  virtual bool GetTrusted(const std::string& path,
+                          const Callback& callback) const OVERRIDE;
   virtual bool HandlesSetting(const std::string& path) const OVERRIDE;
 
-  void WhitelistUser(const std::string& email);
-  void UnwhitelistUser(const std::string& email);
+  static void WhitelistUser(const std::string& email);

[Denis Lagno, 2011/09/20 14:05:22]

Is it good making them static?

Also, you forgot to mark implementation of those methods with //static comment.

[pastarmovj, 2011/09/20 17:11:52]

I intend on getting rid of the special handling of Whitelists in favor of native
ListValue operations as these are now not a special citizens of the signed
settings world.  So I see this only as a transitional solution until I replace
those calls with CrosSettings functions to set ListValues correctly.

On 2011/09/20 14:05:22, Denis Lagno wrote:

+  static void UnwhitelistUser(const std::string& email);
 
   // Updates cached value of the owner.
   static void UpdateCachedOwner(const std::string& email);
 
  private:
   // CrosSettingsProvider implementation.
   virtual void DoSet(const std::string& path, base::Value* value) OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(UserCrosSettingsProvider);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_USER_CROS_SETTINGS_PROVIDER_H_