PART1: Initiated the SignedSettings refactoring.

chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/system_settings_provider.h"
 
 #include <string>
 
 #include "base/i18n/rtl.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 193 matching lines @@
     if (!in_value || !in_value->IsType(Value::TYPE_STRING) ||
         !in_value->GetAsString(&value))
       return;
     const icu::TimeZone* timezone = GetTimezone(value);
     if (!timezone)
       return;
     system::TimezoneSettings::GetInstance()->SetTimezone(*timezone);
   }
 }
 
-bool SystemSettingsProvider::Get(const std::string& path,
-                                 Value** out_value) const {
+const base::Value* SystemSettingsProvider::Get(const std::string& path) const {
   if (path == kSystemTimezone) {
-    *out_value = Value::CreateStringValue(GetKnownTimezoneID(
+    // TODO(pastarmovj): This will leak now if the callee doesn't delete it.

[Mattias Nissler (ping if slow), 2011/09/21 11:12:59]

Isn't passing ownership to the caller the contract of this?

[pastarmovj, 2011/09/23 15:19:32]

This misunderstanding comes again because of the wrong doucmentation of
CrosSettingsProvider::Get. No this is not the contract anymore. The idea is to
cache this one in local_store so that we can use this one instance and return
const refs to it instead of creating new ones every time here. Just like
UserCrosSettings does.

+    // We should anyhow cache this in the local_state.

[Mattias Nissler (ping if slow), 2011/09/21 11:12:59]

If we're caching for all providers, should we move that logic into CrosSettings
so it doesn't need to be reimplemented over and over again?

[pastarmovj, 2011/09/23 15:19:32]

Sounds like a nice idea but it might make ownership a bit more tricky. Will
think of it. Wrote it in my offline ideas list.

+    return Value::CreateStringValue(GetKnownTimezoneID(
         system::TimezoneSettings::GetInstance()->GetTimezone()));
-    return true;
   }
-  return false;
+  return NULL;
+}
+
+// The timezone is always trusted.
+bool SystemSettingsProvider::GetTrusted(const std::string& path,
+                                        const Callback& callback) const {
+  return true;
 }
 
 bool SystemSettingsProvider::HandlesSetting(const std::string& path) const {
   return path == kSystemTimezone;
 }
 
 void SystemSettingsProvider::TimezoneChanged(const icu::TimeZone& timezone) {
   // Fires system setting change notification.
   CrosSettings::Get()->FireObservers(kSystemTimezone);
 }
@@ skipping 75 matching lines @@
     const icu::TimeZone* known_timezone = *iter;
     if (known_timezone->hasSameRules(timezone))
       return GetTimezoneID(*known_timezone);
   }
 
   // Not able to find a matching timezone in our list.
   return string16();
 }
 
 }  // namespace chromeos