PART1: Initiated the SignedSettings refactoring.

chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
 
 #include "base/command_line.h"
 #include "base/stringprintf.h"
 #include "base/task.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/io_thread.h"
+#include "chrome/browser/chromeos/cros_settings.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/power_library.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/login/webui_login_display.h"
 #include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/chromeos/user_cros_settings_provider.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/net/gaia/gaia_urls.h"
 #include "chrome/common/url_constants.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/common/notification_service.h"
 #include "grit/generated_resources.h"
 #include "net/base/dnsrr_resolver.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ skipping 227 matching lines @@
 
   DictionaryValue params;
   params.SetString("startUrl", kGaiaExtStartPage);
   params.SetString("email", email_);
   email_.clear();
 
   const std::string app_locale = g_browser_process->GetApplicationLocale();
   if (!app_locale.empty())
     params.SetString("hl", app_locale);
 
-  params.SetBoolean("createAccount",
-      UserCrosSettingsProvider::cached_allow_new_user());
-  params.SetBoolean("guestSignin",
-      UserCrosSettingsProvider::cached_allow_guest());
+  bool allow_new_user;
+  CrosSettings::Get()->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
+  params.SetBoolean("createAccount", allow_new_user);
+  bool allow_guest;
+  CrosSettings::Get()->GetBoolean(kAccountsPrefAllowGuest, &allow_guest);
+  params.SetBoolean("guestSignin", allow_guest);
   params.SetString("gaiaOrigin", GaiaUrls::GetInstance()->gaia_origin_url());
 
   // Test automation data:
   const CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kAuthExtensionPath)) {
     if (!test_user_.empty()) {
       params.SetString("test_email", test_user_);
       test_user_.clear();
     }
     if (!test_pass_.empty()) {
@@ skipping 97 matching lines @@
   size_t max_non_owner_users = show_guest ? kMaxUsers - 2 : kMaxUsers - 1;
   size_t non_owner_count = 0;
 
   ListValue users_list;
   UserVector users = WebUILoginDisplay::GetInstance()->users();
 
   bool single_user = users.size() == 1;
   for (UserVector::const_iterator it = users.begin();
        it != users.end(); ++it) {
     const std::string& email = it->email();
-    bool is_owner = email == UserCrosSettingsProvider::cached_owner();
+    std::string owner;
+    chromeos::CrosSettings::Get()->GetString(chromeos::kDeviceOwner, &owner);
+    bool is_owner = email == owner;

[Denis Lagno, 2011/09/22 13:54:05]

nit: seems better to put additional parenthesis for readability.

[pastarmovj, 2011/09/23 15:19:32]

Done.

 
     if (non_owner_count < max_non_owner_users || is_owner) {
       DictionaryValue* user_dict = new DictionaryValue();
       user_dict->SetString(kKeyName, it->GetDisplayName());
       user_dict->SetString(kKeyEmailAddress, email);
       user_dict->SetInteger(kKeyOauthTokenStatus, it->oauth_token_status());
 
       // Single user check here is necessary because owner info might not be
       // available when running into login screen on first boot.
       // See http://crosbug.com/12723
@@ skipping 73 matching lines @@
 
   cookie_remover_ = new BrowsingDataRemover(
       Profile::FromBrowserContext(web_ui_->tab_contents()->browser_context()),
       BrowsingDataRemover::EVERYTHING,
       base::Time());
   cookie_remover_->AddObserver(this);
   cookie_remover_->Remove(BrowsingDataRemover::REMOVE_SITE_DATA);
 }
 
 }  // namespace chromeos