PART1: Initiated the SignedSettings refactoring.

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 203 matching lines @@
 }
 
 FilePath GetCachePath(const FilePath& base) {
   return base.Append(chrome::kCacheDirname);
 }
 
 FilePath GetMediaCachePath(const FilePath& base) {
   return base.Append(chrome::kMediaCacheDirname);
 }
 
+void DoInstallDefaultAppsOnUIThread(const FilePath& profile_path,

[Mattias Nissler (ping if slow), 2011/09/26 17:26:37]

Unrelated?

[pastarmovj, 2011/09/29 15:15:03]

Yes this is part of a CL that is landed on trunk but was crashing the browser
while I was working so on the next merge with trunk this changes will disappear.

+                                    const std::list<FilePath>& crx_path_list) {
+  Profile* profile =
+      g_browser_process->profile_manager()->GetProfileByPath(profile_path);
+  if (profile) {
+    ExtensionService* extension_service = profile->GetExtensionService();
+    for (std::list<FilePath>::const_iterator iter = crx_path_list.begin();
+         iter != crx_path_list.end(); ++iter) {
+      scoped_refptr<CrxInstaller> crx_installer =
+          extension_service->MakeCrxInstaller(NULL);
+      crx_installer->set_allow_silent_install(true);
+      crx_installer->set_delete_source(false);
+      crx_installer->set_install_cause(extension_misc::INSTALL_CAUSE_UPDATE);
+      crx_installer->InstallCrx(*iter);
+    }
+  }
+}
+
+void InstallDefaultApps(const FilePath& profile_path) {
+  FilePath apps_dir;
+  FilePath file;
+  std::list<FilePath> crx_path_list;
+
+  if (PathService::Get(chrome::DIR_DEFAULT_APPS, &apps_dir)) {
+    file_util::FileEnumerator file_enumerator(apps_dir, false,
+        file_util::FileEnumerator::FILES);
+    while (!(file = file_enumerator.Next()).value().empty()) {
+      if (LowerCaseEqualsASCII(file.Extension(), ".crx"))
+        crx_path_list.push_back(file);
+    }
+  }
+  // No need to post the task if nothing was there to install.
+  if (!crx_path_list.size())
+    return;
+
+  // Finish the install on the UI thread.
+  BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+                          base::Bind(&DoInstallDefaultAppsOnUIThread,
+                                     profile_path, crx_path_list));
+}
+
 // Simple task to log the size of the current profile.
 class ProfileSizeTask : public Task {
  public:
   explicit ProfileSizeTask(const FilePath& path) : path_(path) {}
   virtual ~ProfileSizeTask() {}
 
   virtual void Run();
  private:
   FilePath path_;
 };
@@ skipping 307 matching lines @@
 #elif defined(OS_MACOSX)
   std::string brand = keystone_glue::BrandCode();
 #else
   std::string brand;
 #endif
   // TODO(caitkp): when we move to multi-profiles (M16) we will want to change
   // this check, as |FirstRun::IsChromeFirstRun()| checks for the first run
   // ever, not first run per profile.
   if (FirstRun::IsChromeFirstRun() &&
       !LowerCaseEqualsASCII(brand, "ecdb")) {
-    InstallDefaultApps();
+    BrowserThread::PostTask(
+        BrowserThread::FILE, FROM_HERE,
+        base::Bind(&InstallDefaultApps, GetPath()));
   }
 #endif
 
   extension_service_->Init();
 
   if (extensions_enabled) {
     // Load any extensions specified with --load-extension.
     if (command_line->HasSwitch(switches::kLoadExtension)) {
       FilePath path = command_line->GetSwitchValuePath(
           switches::kLoadExtension);
@@ skipping 19 matching lines @@
   if (!command_line->HasSwitch(switches::kImport) &&
       !command_line->HasSwitch(switches::kImportFromFile)) {
     if (g_browser_process->profile_manager()->will_import()) {
       extension_service_->InitEventRoutersAfterImport();
     } else {
       extension_service_->InitEventRouters();
     }
   }
 }
 
-void ProfileImpl::InstallDefaultApps() {
-  FilePath apps_dir;
-  FilePath file;
-  std::list<FilePath> crx_path_list;
-
-  if (PathService::Get(chrome::DIR_DEFAULT_APPS, &apps_dir)) {
-    file_util::FileEnumerator file_enumerator(apps_dir, false,
-        file_util::FileEnumerator::FILES);
-    while (!(file = file_enumerator.Next()).value().empty()) {
-      if (LowerCaseEqualsASCII(file.Extension(), ".crx"))
-        crx_path_list.push_back(file);
-    }
-  }
-
-  for (std::list<FilePath>::iterator iter = crx_path_list.begin();
-       iter != crx_path_list.end(); ++iter) {
-    scoped_refptr<CrxInstaller> crx_installer =
-        extension_service_->MakeCrxInstaller(NULL);
-    crx_installer->set_allow_silent_install(true);
-    crx_installer->set_delete_source(false);
-    crx_installer->set_install_cause(extension_misc::INSTALL_CAUSE_UPDATE);
-    crx_installer->InstallCrx(*iter);
-  }
-}
-
 void ProfileImpl::RegisterComponentExtensions() {
   // Register the component extensions.
   //
   // Component extension manifest must contain a 'key' property with a unique
   // public key, serialized in base64. You can create a suitable value with the
   // following commands on a unixy system:
   //
   //   ssh-keygen -t rsa -b 1024 -N '' -f /tmp/key.pem
   //   openssl rsa -pubout -outform DER < /tmp/key.pem 2>/dev/null | base64 -w 0
   typedef std::list<std::pair<FilePath::StringType, int> >
@@ skipping 1195 matching lines @@
 SpellCheckProfile* ProfileImpl::GetSpellCheckProfile() {
   if (!spellcheck_profile_.get())
     spellcheck_profile_.reset(new SpellCheckProfile());
   return spellcheck_profile_.get();
 }
 
 void ProfileImpl::SetDownloadManagerDelegate(
     ChromeDownloadManagerDelegate* delegate) {
   download_manager_delegate_ = delegate;
 }