PART1: Initiated the SignedSettings refactoring.

chrome/browser/chromeos/proxy_cros_settings_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/proxy_cros_settings_provider.h"
 
 #include "base/string_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/cros_settings.h"
 #include "chrome/browser/ui/browser_list.h"
@@ skipping 213 matching lines @@
         std::string val;
         if (list_value->GetString(x, &val)) {
           bypass_rules.AddRuleFromString(val);
         }
       }
       config_service->UISetProxyConfigBypassRules(bypass_rules);
     }
   }
 }
 
-bool ProxyCrosSettingsProvider::Get(const std::string& path,
-                                    Value** out_value) const {
+const Value* ProxyCrosSettingsProvider::Get(const std::string& path) const {
   bool found = false;
-  bool managed = false;
   Value* data = NULL;
   chromeos::ProxyConfigServiceImpl* config_service = GetConfigService();
   chromeos::ProxyConfigServiceImpl::ProxyConfig config;
   config_service->UIGetProxyConfig(&config);
 
   if (path == kProxyPacUrl) {
     // Only show pacurl for pac-script mode.
     if (config.mode ==
             chromeos::ProxyConfigServiceImpl::ProxyConfig::MODE_PAC_SCRIPT &&
         config.automatic_proxy.pac_url.is_valid()) {
@@ skipping 48 matching lines @@
     found = true;
   } else if (path == kProxySocksPort) {
     data = CreateServerPortValue(config.socks_proxy);
     found = true;
   } else if (path == kProxyIgnoreList) {
     ListValue* list =  new ListValue();
     net::ProxyBypassRules::RuleList bypass_rules = config.bypass_rules.rules();
     for (size_t x = 0; x < bypass_rules.size(); x++) {
       list->Append(Value::CreateStringValue(bypass_rules[x]->ToString()));
     }
-    *out_value = list;
-    return true;
+    return list;
   }
   if (found) {
-    DictionaryValue* dict = new DictionaryValue;
     if (!data)
       data = Value::CreateStringValue("");
-    dict->Set("value", data);
-    dict->SetBoolean("managed", managed);
-    *out_value = dict;
-    return true;
-  } else {
-    *out_value = NULL;
-    return false;
+    return data;
   }
+  return NULL;
+}
+
+bool ProxyCrosSettingsProvider::GetTrusted(
+    const std::string& path,
+    const base::Closure& callback) const {
+  // This will bounce the query to UserCrosSettingsProvider until
+  // ProxyConfigService can report this too.
+  // TODO(pastarmovj): Extend ProxyConfigService to support this kind of query.
+  return CrosSettings::Get()->GetTrusted(kAccountsPrefAllowGuest, callback);

[Mattias Nissler (ping if slow), 2011/09/26 17:26:37]

This is not correct either, since we might also be waiting from flimflam. Can
you just put a NOTREACHED() for now and fix the TODO soonish?

[pastarmovj, 2011/09/29 15:15:03]

Done.

 }
 
 bool ProxyCrosSettingsProvider::HandlesSetting(const std::string& path) const {
   return ::StartsWithASCII(path, "cros.session.proxy", true);
 }
 
 //----------------- ProxyCrosSettingsProvider: private methods -----------------
 
 chromeos::ProxyConfigServiceImpl*
     ProxyCrosSettingsProvider::GetConfigService() const {
@@ skipping 36 matching lines @@
 }
 
 Value* ProxyCrosSettingsProvider::CreateServerPortValue(
     const ProxyConfigServiceImpl::ProxyConfig::ManualProxy& proxy) const {
   return proxy.server.is_valid() ?
          Value::CreateIntegerValue(proxy.server.host_port_pair().port()) :
          NULL;
 }
 
 }  // namespace chromeos