PART1: Initiated the SignedSettings refactoring.

chrome/browser/chromeos/cros_settings.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_
 #define CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/hash_tables.h"
 #include "base/memory/singleton.h"
 #include "base/observer_list.h"
 #include "base/threading/non_thread_safe.h"
 #include "chrome/browser/chromeos/cros_settings_names.h"
+#include "chrome/browser/chromeos/cros_settings_provider.h"
 #include "content/common/notification_observer.h"
 
 namespace base {
 template <typename T> struct DefaultLazyInstanceTraits;
 class Value;
+class ListValue;

[Mattias Nissler (ping if slow), 2011/09/26 17:26:37]

alphabetize

[pastarmovj, 2011/09/29 15:15:03]

Done. Sorry about that I went for the logical order instead of the alphabetical
one.

 }
 
 namespace chromeos {
 
-class CrosSettingsProvider;
-
 // A class manages per-device/global settings.
 class CrosSettings : public base::NonThreadSafe {
  public:
   // Class factory.
   static CrosSettings* Get();
 
   // Helper function to test if given path is a value cros settings name.
   static bool IsCrosSettings(const std::string& path);
 
   // Sets |in_value| to given |path| in cros settings.
   // Note that this takes ownership of |in_value|.
   void Set(const std::string& path, base::Value* in_value);
 
   // Fires system setting change notification.
+  // TODO(pastarmovj): Consider to remove this function from the public i-face.

[Mattias Nissler (ping if slow), 2011/09/26 17:26:37]

spell it out, please.

[pastarmovj, 2011/09/29 15:15:03]

Done. You are aware that you made me line break right? ;)

   void FireObservers(const char* path);
 
   // Gets settings value of given |path| to |out_value|.

[Mattias Nissler (ping if slow), 2011/09/26 17:26:37]

comment outdated.

[pastarmovj, 2011/09/29 15:15:03]

Not only the comment is outdated the whole function is not there anymore :)

+  const base::Value* HasPref(const std::string& path) const;

[Mattias Nissler (ping if slow), 2011/09/26 17:26:37]

shouldn't this rather return bool? Then again, if it's the same as GetPref() why
do we have both?

[pastarmovj, 2011/09/29 15:15:03]

Done.

+
+  // Gets settings value of given |path| to |out_value|.
+  const base::Value* GetPref(const std::string& path) const;
+
+  // Gets settings value of given |path| to |out_value|.
   // Note that the caller owns |out_value| returned.
   bool Get(const std::string& path, base::Value** out_value) const;

[Mattias Nissler (ping if slow), 2011/09/26 17:26:37]

Why is there both Get() and GetPref()?

[pastarmovj, 2011/09/29 15:15:03]

Get is what UI used to get Pref Dictionaries whapped around a copy of the Value
whereas GetPref only returns a const pointer to the original data. Now Get is
gone and moved to where it belongs the UI level.

 
+  // Gets settings value of given |path| from the trusted store. It will call
+  // the |callback| function with the value of the setting or NULL if it could
+  // not be retrieved.
+  bool GetTrusted(const std::string& path,
+                  const base::Closure& callback) const;
+
   // Convenience forms of Set().  These methods will replace any existing
   // value at that path, even if it has a different type.
   void SetBoolean(const std::string& path, bool in_value);
   void SetInteger(const std::string& path, int in_value);
   void SetDouble(const std::string& path, double in_value);
   void SetString(const std::string& path, const std::string& in_value);
 
   // These are convenience forms of Get().  The value will be retrieved
   // and the return value will be true if the path is valid and the value at
   // the end of the path can be returned in the form specified.
   bool GetBoolean(const std::string& path, bool* out_value) const;
   bool GetInteger(const std::string& path, int* out_value) const;
   bool GetDouble(const std::string& path, double* out_value) const;
   bool GetString(const std::string& path, std::string* out_value) const;
+  bool GetList(const std::string& path,
+               const base::ListValue** out_value) const;
 
   // adding/removing of providers
   bool AddSettingsProvider(CrosSettingsProvider* provider);
   bool RemoveSettingsProvider(CrosSettingsProvider* provider);
 
   // If the pref at the given path changes, we call the observer's Observe
   // method with PREF_CHANGED.
   void AddSettingsObserver(const char* path, NotificationObserver* obs);
   void RemoveSettingsObserver(const char* path, NotificationObserver* obs);
 
@@ skipping 14 matching lines @@
   CrosSettings();
   ~CrosSettings();
   friend struct base::DefaultLazyInstanceTraits<CrosSettings>;
 
   DISALLOW_COPY_AND_ASSIGN(CrosSettings);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_H_