PART1: Initiated the SignedSettings refactoring.

chrome/browser/automation/testing_automation_provider_chromeos.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include "base/command_line.h"
 #include "base/i18n/time_formatting.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/automation/automation_provider_json.h"
 #include "chrome/browser/automation/automation_provider_observers.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/audio_handler.h"
+#include "chrome/browser/chromeos/cros_settings.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/cros/network_library.h"
 #include "chrome/browser/chromeos/cros/power_library.h"
 #include "chrome/browser/chromeos/cros/screen_lock_library.h"
 #include "chrome/browser/chromeos/cros/update_library.h"
 #include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.h"
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 #include "chrome/browser/chromeos/login/login_display.h"
 #include "chrome/browser/chromeos/login/login_display_host.h"
 #include "chrome/browser/chromeos/login/screen_locker.h"
 #include "chrome/browser/chromeos/login/webui_login_display.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 #include "chrome/browser/chromeos/options/take_photo_dialog.h"
-#include "chrome/browser/chromeos/proxy_cros_settings_provider.h"
 #include "chrome/browser/chromeos/system/timezone_settings.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/cloud_policy_cache_base.h"
 #include "chrome/browser/policy/cloud_policy_data_store.h"
 #include "chrome/browser/policy/cloud_policy_subsystem.h"
 #include "chrome/browser/policy/enterprise_install_attributes.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/views/window.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 21 matching lines @@
 
 DictionaryValue* GetNetworkInfoDict(const chromeos::Network* network) {
   DictionaryValue* item = new DictionaryValue;
   item->SetString("name", network->name());
   item->SetString("device_path", network->device_path());
   item->SetString("ip_address", network->ip_address());
   item->SetString("status", network->GetStateString());
   return item;
 }
 
-Value* GetProxySetting(const std::string& setting_name) {
-  chromeos::ProxyCrosSettingsProvider settings_provider;
+const Value* GetProxySetting(const std::string& setting_name) {
   std::string setting_path = "cros.session.proxy.";
   setting_path.append(setting_name);
 
-  if (setting_name == "ignorelist") {
-    Value* value;
-    if (settings_provider.Get(setting_path, &value))
-      return value;
-  } else {
-    Value* setting;
-    if (settings_provider.Get(setting_path, &setting)) {

[Mattias Nissler (ping if slow), 2011/09/26 17:26:37]

What's the plan for the auto-removal code here? Did you move it some place else?

[pastarmovj, 2011/09/29 15:15:03]

We are returning a const pointer to the original data from GetPref so nothing to
destroy we don't return copies anymore.

-      DictionaryValue* setting_dict = static_cast<DictionaryValue*>(setting);
-      Value* value;
-      bool found = setting_dict->Remove("value", &value);
-      delete setting;
-      if (found)
-        return value;
-    }
-  }
-  return NULL;
+  return chromeos::CrosSettings::Get()->GetPref(setting_path);
 }
 
 const char* UpdateStatusToString(chromeos::UpdateStatusOperation status) {
   switch (status) {
     case chromeos::UPDATE_STATUS_IDLE:
       return "idle";
     case chromeos::UPDATE_STATUS_CHECKING_FOR_UPDATE:
       return "checking for update";
     case chromeos::UPDATE_STATUS_UPDATE_AVAILABLE:
       return "update available";
@@ skipping 415 matching lines @@
 }
 
 void TestingAutomationProvider::GetProxySettings(DictionaryValue* args,
                                                  IPC::Message* reply_message) {
   const char* settings[] = { "pacurl", "singlehttp", "singlehttpport",
                              "httpurl", "httpport", "httpsurl", "httpsport",
                              "type", "single", "ftpurl", "ftpport",
                              "socks", "socksport", "ignorelist" };
 
   scoped_ptr<DictionaryValue> return_value(new DictionaryValue);
-  chromeos::ProxyCrosSettingsProvider settings_provider;
 
   for (size_t i = 0; i < arraysize(settings); ++i) {
-    Value* setting = GetProxySetting(settings[i]);
+    const Value* setting = GetProxySetting(settings[i]);
     if (setting)
-      return_value->Set(settings[i], setting);
+      return_value->Set(settings[i], setting->DeepCopy());
   }
 
   AutomationJSONReply(this, reply_message).SendSuccess(return_value.get());
 }
 
 void TestingAutomationProvider::SetProxySettings(DictionaryValue* args,
                                                 IPC::Message* reply_message) {
   AutomationJSONReply reply(this, reply_message);
   std::string key;
   Value* value;
   if (!args->GetString("key", &key) || !args->Get("value", &value)) {
     reply.SendError("Invalid or missing args.");
     return;
   }
 
   std::string setting_path = "cros.session.proxy.";
   setting_path.append(key);
 
   // ProxyCrosSettingsProvider will own the Value* passed to Set().
-  chromeos::ProxyCrosSettingsProvider().Set(setting_path, value->DeepCopy());
+  chromeos::CrosSettings::Get()->Set(setting_path, value->DeepCopy());
   reply.SendSuccess(NULL);
 }
 
 void TestingAutomationProvider::ConnectToWifiNetwork(
     DictionaryValue* args, IPC::Message* reply_message) {
   if (!EnsureCrosLibraryLoaded(this, reply_message))
     return;
 
   AutomationJSONReply reply(this, reply_message);
   std::string service_path, password;
@@ skipping 572 matching lines @@
 
   // Set up an observer (it will delete itself).
   take_photo_dialog->AddObserver(new PhotoCaptureObserver(
       this, reply_message));
 
   views::Widget* window = browser::CreateViewsWindow(
       browser->window()->GetNativeHandle(), take_photo_dialog);
   window->SetAlwaysOnTop(true);
   window->Show();
 }