Issue 7867036: d8 external array c'tors: allow parameters that can be converted to numbers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7867036: d8 external array c'tors: allow parameters that can be converted to numbers (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow

Modified:
9 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

d8 external array c'tors: allow parameters that can be converted to numbers BUG=v8:1681 TEST=d8 accepts: var a = new Int32Array("2"); Committed: http://code.google.com/p/v8/source/detail?r=9243

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
	M	src/d8.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download
	M	test/mjsunit/external-array.js	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2011/09/12 12:18:17, Jakob wrote: > PTAL. LGTM. Not sure if we should have test ...

9 years, 3 months ago (2011-09-12 12:30:22 UTC) #2

Well, yeah. Test added, landing.