Add routing id and notification type to accessibility logging.

content/common/view_messages.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for page rendering.
 // Multiply-included message file, hence no include guard.
 
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "content/common/common_param_traits.h"
@@ skipping 91 matching lines @@
 
     // Text was inserted in a node with text content.
     TEXT_INSERTED,
 
     // Text was removed in a node with text content.
     TEXT_REMOVED,
 
     // The node value has changed.
     VALUE_CHANGED,
   };
+
+  #ifndef NDEBUG
+    static const std::string DebugString(Value value) {

[brettw, 2011/09/15 18:05:25]

Can this big function be not inlined? Otherwise we'll get all these strings in
each translation unit.

[David Tseng, 2011/09/15 21:58:45]

Only true of debug builds though?
Don't feel that strongly about it, so
Done.

[brettw, 2011/09/16 04:52:23]

Duplicating this code all over makes the .o files bigger and makes more work for
the linker. So it "shouldn't" affect the outcome, but makes developer's lives
slightly better when we do this consistently.

+      switch (value) {
+        case ACTIVE_DESCENDANT_CHANGED: return "active descendant changed";
+        case ALERT: return "alert";
+        case CHECK_STATE_CHANGED: return "checked state changed";
+        case CHILDREN_CHANGED: return "children changed";
+        case FOCUS_CHANGED: return "focus changed";
+        case LAYOUT_COMPLETE: return "layout complete";
+        case LIVE_REGION_CHANGED: return "live region changed";
+        case LOAD_COMPLETE: return "load complete";
+        case MENU_LIST_VALUE_CHANGED: return "menu list changed";
+        case OBJECT_SHOW: return "object show";
+        case OBJECT_HIDE: return "object hide";
+        case ROW_COUNT_CHANGED: return "row count changed";
+        case ROW_COLLAPSED: return "row collapsed";
+        case ROW_EXPANDED: return "row expanded";
+        case SCROLLED_TO_ANCHOR: return "scrolled to anchor";
+        case SELECTED_CHILDREN_CHANGED: return "selected children changed";
+        case SELECTED_TEXT_CHANGED: return "selected text changed";
+        case TEXT_INSERTED: return "text inserted";
+      case TEXT_REMOVED: return "text removed";

[brettw, 2011/09/15 18:05:25]

Indenting

[David Tseng, 2011/09/15 21:58:45]

Done.

+        case VALUE_CHANGED: return "value changed";
+      }
+      NOTREACHED();
+      return "";
+    }
+  #endif  // NDEBUG
 };
 
 // Values that may be OR'd together to form the 'flags' parameter of the
 // ViewMsg_EnablePreferredSizeChangedMode message.
 enum ViewHostMsg_EnablePreferredSizeChangedMode_Flags {
   kPreferredSizeNothing,
   kPreferredSizeWidth = 1 << 0,
   // Requesting the height currently requires a polling loop in render_view.cc.
   kPreferredSizeHeightThisIsSlow = 1 << 1,
 };
@@ skipping 2003 matching lines @@
                     int32 /* complete status */)
 
 // Request updated information about the client firewall traversal policy.
 // Will result in a ViewMsg_UpdateRemoteAccessClientFirewallTraversal message
 // being sent back.
 IPC_MESSAGE_ROUTED0(ViewHostMsg_RequestRemoteAccessClientFirewallTraversal)
 
 // Notifies the browser of an event occurring in the media pipeline.
 IPC_MESSAGE_CONTROL1(ViewHostMsg_MediaLogEvent,
                      media::MediaLogEvent /* event */)