Issue 7866041: Improved pretty printing of VAR PROXY and some control flow AST nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7866041: Improved pretty printing of VAR PROXY and some control flow AST nodes. (Closed)

Created:
9 years, 3 months ago by Sven Panne

Modified:
9 years, 3 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Improved pretty printing of VAR PROXY and some control flow AST nodes. Committed: http://code.google.com/p/v8/source/detail?r=9245

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -25 lines)			Patch
	M	src/prettyprinter.cc	View	1 2	2 chunks	+22 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

danno

9 years, 3 months ago (2011-09-12 13:48:39 UTC) #2

lgtm with nit

http://codereview.chromium.org/7866041/diff/3001/src/prettyprinter.cc
File src/prettyprinter.cc (right):

http://codereview.chromium.org/7866041/diff/3001/src/prettyprinter.cc#newcode617
src/prettyprinter.cc:617: 
remove line

Expand Messages | Collapse Messages