Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 7866040: d8 external array c'tors: fix double-to-uint32 semantics (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow
Modified:
9 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

d8 external array c'tors: fix double-to-uint32 semantics TEST=mjsunit/external-array Committed: http://code.google.com/p/v8/source/detail?r=9244

Patch Set 1 #

Patch Set 2 : better error messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/d8.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
PTAL.
9 years, 3 months ago (2011-09-12 13:17:55 UTC) #1
Yang
9 years, 3 months ago (2011-09-12 13:34:46 UTC) #2
On 2011/09/12 13:17:55, Jakob wrote:
> PTAL.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698