Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 7866036: micro optimize CommandLine.GetSwitchPrefixLength (Closed)

Created:
9 years, 3 months ago by joth
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

micro optimize CommandLine.GetSwitchPrefixLength avoid searching the entire length of each switch for the -- prefix, as we know it can only exist at the start. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100918

Patch Set 1 #

Patch Set 2 : ' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M base/command_line.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/command_line_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
joth
evan selected as you were the last OWNER to edit this file TIA,
9 years, 3 months ago (2011-09-12 13:14:13 UTC) #1
Evan Martin
Why? Does this show up in a profile? LGTM anyway
9 years, 3 months ago (2011-09-12 14:47:21 UTC) #2
M-A Ruel
On 2011/09/12 14:47:21, Evan Martin wrote: > Why? Does this show up in a profile? ...
9 years, 3 months ago (2011-09-13 13:19:55 UTC) #3
joth
OK thanks good to know - I'd setup a new git checkout but not yet ...
9 years, 3 months ago (2011-09-13 14:27:38 UTC) #4
M-A Ruel
No need to svn init, you just need to set your tracking branch correctly. M-A ...
9 years, 3 months ago (2011-09-13 14:28:35 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-13 15:45:35 UTC) #6
Change committed as 100918

Powered by Google App Engine
This is Rietveld 408576698