Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 7866026: Added trace query code and wired tracing through BrowserProxy so tests can run traces. (Closed)

Created:
9 years, 3 months ago by jbates
Modified:
9 years, 3 months ago
CC:
chromium-reviews, scheib, joth, Vangelis Kokkevis
Visibility:
Public.

Description

Added trace query code and wired tracing through BrowserProxy so tests can run traces. This change: - adds classes trace::Query and TraceAnalyzer to make it easy to search through trace data for specific events. - adds Begin/EndTracing to BrowserProxy. - adds "did it run on GPU" check to frame_rate_tests.cc using above features. BUG=95714 TEST=base_unittests

Patch Set 1 #

Patch Set 2 : removed stdio #

Patch Set 3 : wip #

Patch Set 4 : wip #

Patch Set 5 : closer #

Patch Set 6 : . #

Patch Set 7 : added unittests #

Patch Set 8 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1227 lines, -3 lines) Patch
M base/base.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M base/debug/trace_event.h View 1 2 3 4 5 6 7 5 chunks +65 lines, -1 line 0 comments Download
M base/debug/trace_event.cc View 1 2 3 4 3 chunks +136 lines, -0 lines 0 comments Download
A base/debug/trace_event_test_utils.h View 1 2 3 4 5 6 7 1 chunk +228 lines, -0 lines 0 comments Download
A base/debug/trace_event_test_utils.cc View 1 2 3 4 5 6 7 1 chunk +493 lines, -0 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 1 2 3 4 5 6 2 chunks +105 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 7 chunks +22 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 6 7 3 chunks +71 lines, -0 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/test/automation/browser_proxy.h View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/test/automation/browser_proxy.cc View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 1 2 3 4 5 6 6 chunks +31 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jbates
This is a big one...
9 years, 3 months ago (2011-09-19 23:32:33 UTC) #1
nduca
On 2011/09/19 23:32:33, jbates wrote: > This is a big one... Is there any way ...
9 years, 3 months ago (2011-09-20 16:52:34 UTC) #2
jbates
9 years, 3 months ago (2011-09-20 17:02:04 UTC) #3
On 2011/09/20 16:52:34, nduca wrote:
> On 2011/09/19 23:32:33, jbates wrote:
> > This is a big one...
> 
> Is there any way to tease this into a few smaller CLs? Typically, when I do
> these I do one mega mega one like this to get it all working. Then break it
> apart into smaller pieces  --- it takes longer, but it gets much better review
> coverage that way.

Absolutely, I'll split em up.

Powered by Google App Engine
This is Rietveld 408576698