New implementation of font precache on Windows.

chrome/common/chrome_utility_messages.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, so no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 128 matching lines @@
 // Reply when the utility process has succeeded in rendering the PDF.
 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_RenderPDFPagesToMetafile_Succeeded,
                      int)       // Highest rendered page number
 
 // Reply when an error occured rendering the PDF.
 IPC_MESSAGE_CONTROL0(ChromeUtilityHostMsg_RenderPDFPagesToMetafile_Failed)
 
 #if defined(OS_WIN)
 // Request that the given font be loaded by the host so it's cached by the
 // OS. Please see ChildProcessHost::PreCacheFont for details.
-IPC_SYNC_MESSAGE_CONTROL1_0(ChromeUtilityHostMsg_PreCacheFont,
-                            LOGFONT /* font data */)
+IPC_SYNC_MESSAGE_CONTROL2_0(ChromeUtilityHostMsg_PreCacheFont,
+                            LOGFONT /* font data */,
+                            int /*pid*/)

[nsylvain, 2011/09/13 19:32:18]

should you really trust the renderer with the pid? A malicious renderer could
potentially screw your cache.  I'm pretty sure there is a way to get the
renderer pid within the message handler.

[arthurhsu, 2011/09/13 20:58:32]

This one is a service utility process host, which is used internally by
printing.  The other one used by renderer process is changed.

+
+// Release the cached font
+IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_ReleaseCachedFont,
+                     int /*pid*/)
 #endif  // defined(OS_WIN)
 
 // Reply when the utility process successfully parsed a JSON string.
 //
 // WARNING: The result can be of any Value subclass type, but we can't easily
 // pass indeterminate value types by const object reference with our IPC macros,
 // so we put the result Value into a ListValue. Handlers should examine the
 // first (and only) element of the ListValue for the actual result.
 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_ParseJSON_Succeeded,
                      ListValue)
 
 // Reply when the utility process failed in parsing a JSON string.
 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_ParseJSON_Failed,
                      std::string /* error message, if any*/)
 
 // Reply when the utility process has succeeded in obtaining the printer
 // capabilities and defaults.
 IPC_MESSAGE_CONTROL2(ChromeUtilityHostMsg_GetPrinterCapsAndDefaults_Succeeded,
                      std::string /* printer name */,
                      printing::PrinterCapsAndDefaults)
 
 // Reply when the utility process has failed to obtain the printer
 // capabilities and defaults.
 IPC_MESSAGE_CONTROL1(ChromeUtilityHostMsg_GetPrinterCapsAndDefaults_Failed,
                      std::string /* printer name */)