chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 7866011: Switch to the new client-side phishing model that uses Murmurhash for word hashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 7866011: Switch to the new client-side phishing model that uses Murmurhash for word hashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile problems and add another test Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index 55c0f0ea28bb4a4707d844c0381f708b5cb46437..53e8dfafd478310d7e4128b96f5285378a788e7a 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -565,7 +565,6 @@ TEST_F(ClientSideDetectionServiceTest, ModelHasValidHashIds) {

model.add_hashes("bla");

EXPECT_TRUE(ClientSideDetectionService::ModelHasValidHashIds(model));

model.add_page_term(0);

- model.add_page_word(0);

EXPECT_TRUE(ClientSideDetectionService::ModelHasValidHashIds(model));

model.add_page_term(-1);

@@ -575,13 +574,6 @@ TEST_F(ClientSideDetectionServiceTest, ModelHasValidHashIds) {

model.set_page_term(1, 0);

EXPECT_TRUE(ClientSideDetectionService::ModelHasValidHashIds(model));

- model.add_page_word(-2);

- EXPECT_FALSE(ClientSideDetectionService::ModelHasValidHashIds(model));

- model.set_page_word(1, 2);

- EXPECT_FALSE(ClientSideDetectionService::ModelHasValidHashIds(model));

- model.set_page_word(1, 0);

- EXPECT_TRUE(ClientSideDetectionService::ModelHasValidHashIds(model));

// Test bad rules.

model.add_hashes("blu");

ClientSideModel::Rule* rule = model.add_rule();

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service.cc ('k') | chrome/chrome_renderer.gypi » ('j') | no next file with comments »