Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 7865027: net: update public key block for the correct Cyber CA certs. (Closed)

Created:
9 years, 3 months ago by agl
Modified:
9 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

net: update public key block for the correct Cyber CA certs. Thanks to nahi on Twitter for pointing out that I had the wrong certificate for DigiNotar's Cyber CA and thus blocked the wrong public key. According to the audit report, this isn't panic-worthy as the misissued certs off this intermediate have expired. BUG=96252 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100852

Patch Set 1 #

Total comments: 4

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -2 lines) Patch
M net/base/x509_certificate.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/x509_certificate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/x509_certificate_unittest.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/diginotar_cyber_ca.pem View 1 chunk +32 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/diginotar_pkioverheid.pem View 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/diginotar_pkioverheid_g2.pem View 1 chunk +38 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/diginotar_root_ca.pem View 1 chunk +32 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/diginotar_services_1024_ca.pem View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
agl
9 years, 3 months ago (2011-09-12 13:44:22 UTC) #1
wtc
LGTM. Probably should also reference the original bug BUG=94673. http://codereview.chromium.org/7865027/diff/1/net/base/x509_certificate.cc File net/base/x509_certificate.cc (right): http://codereview.chromium.org/7865027/diff/1/net/base/x509_certificate.cc#newcode964 net/base/x509_certificate.cc:964: ...
9 years, 3 months ago (2011-09-12 18:59:52 UTC) #2
agl
http://codereview.chromium.org/7865027/diff/1/net/base/x509_certificate.cc File net/base/x509_certificate.cc (right): http://codereview.chromium.org/7865027/diff/1/net/base/x509_certificate.cc#newcode964 net/base/x509_certificate.cc:964: // Issuer: CN=Entrust.net x2 and self-signed On 2011/09/12 18:59:53, ...
9 years, 3 months ago (2011-09-12 22:34:28 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-13 03:36:23 UTC) #4
Change committed as 100852

Powered by Google App Engine
This is Rietveld 408576698