Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: src/platform-macos.cc

Issue 7865025: Move aligned allocation to the platform files. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Removed leftover debug code. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform-linux.cc ('k') | src/platform-win32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform-macos.cc
diff --git a/src/platform-macos.cc b/src/platform-macos.cc
index 0671a923b3f264df26cb1139216db310a16e6747..5ba13296dadac020aeb166625e53f6ddcf51cfa8 100644
--- a/src/platform-macos.cc
+++ b/src/platform-macos.cc
@@ -1,4 +1,4 @@
-// Copyright 2006-2008 the V8 project authors. All rights reserved.
+// Copyright 2011 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -334,12 +334,58 @@ int OS::StackWalk(Vector<StackFrame> frames) {
}
-VirtualMemory::VirtualMemory(size_t size) {
- address_ = ReserveRegion(size);
+VirtualMemory::VirtualMemory() : address_(NULL), size_(size) { }
+
+
+VirtualMemory::VirtualMemory(size_t size)
+ : address_(ReserveRegion(size)), size_(size) { }
+
+
+VirtualMemory::VirtualMemory(size_t size, size_t alignment)
+ : address_(NULL), size_(0) {
+ ASSERT(IsAligned(alignment, static_cast<intptr_t>(OS::AllocateAlignment())));
+ size_t request_size = RoundUp(size + alignment,
+ static_cast<intptr_t>(OS::AllocateAlignment()));
+ void* reservation = mmap(GetRandomMmapAddr(),
+ request_size,
+ PROT_NONE,
+ MAP_PRIVATE | MAP_ANONYMOUS | MAP_NORESERVE,
+ kMmapFd,
+ kMmapFdOffset);
+ if (reservation == MAP_FAILED) return;
+ Address base = static_cast<Address>(reservation);
+ Address aligned_base = RoundUp(base, alignment);
+ ASSERT(base <= aligned_base);
+
+ // Unmap extra memory reserved before and after the desired block.
+ size_t bytes_prior = static_cast<size_t>(aligned_base - base);
+ if (bytes_prior > 0) {
+ munmap(base, bytes_prior);
+ }
+ if (static_cast<size_t>(aligned_base - base) < request_size - size) {
+ munmap(aligned_base + size, request_size - size - bytes_prior);
+ }
+
+ address_ = static_cast<void*>(aligned_base);
size_ = size;
}
+VirtualMemory::~VirtualMemory() {
+ if (IsReserved()) {
+ bool result = ReleaseRegion(address(), size());
+ ASSERT(result);
+ USE(result);
+ }
+}
+
+
+void VirtualMemory::Reset() {
+ address_ = NULL;
+ size_ = 0;
+}
+
+
void* VirtualMemory::ReserveRegion(size_t size) {
void* result = mmap(NULL,
size,
@@ -354,15 +400,8 @@ void* VirtualMemory::ReserveRegion(size_t size) {
}
-VirtualMemory::~VirtualMemory() {
- if (IsReserved()) {
- if (ReleaseRegion(address_, size_)) address_ = MAP_FAILED;
- }
-}
-
-
bool VirtualMemory::IsReserved() {
- return address_ != MAP_FAILED;
+ return address_ != NULL;
}
« no previous file with comments | « src/platform-linux.cc ('k') | src/platform-win32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698