third_party/tcmalloc/chromium/src/malloc_hook.cc - Issue 7865021: Deep-Memory-Profiler (DMP) implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/malloc_hook.cc

Issue 7865021: Deep-Memory-Profiler (DMP) implementation (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fixed bugs Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/tcmalloc/chromium/src/malloc_hook.cc

diff --git a/third_party/tcmalloc/chromium/src/malloc_hook.cc b/third_party/tcmalloc/chromium/src/malloc_hook.cc

index f6af7d816179e91afabcc6838ad5fbb99ec1791e..1b884fa36ee4c554909b854beffb09843c7c60c9 100644

--- a/third_party/tcmalloc/chromium/src/malloc_hook.cc

+++ b/third_party/tcmalloc/chromium/src/malloc_hook.cc

@@ -677,7 +677,10 @@ extern "C" int MallocHook_GetCallerStackTrace(void** result, int max_depth,

if (InHookCaller(stack[i])) {

RAW_VLOG(10, "Found hooked allocator at %d: %p <- %p",

i, stack[i], stack[i+1]);

- i += 1; // skip hook caller frame

+ // i += 1; // skip hook caller frame

+ // In deep profiler, we want to know the caller frame to

+ // distinguish mmap from tcmalloc

depth -= i; // correct depth

if (depth > max_depth) depth = max_depth;

copy(stack + i, stack + i + depth, result);