Issue 7864031: If --views-desktop is specified from the command line, respect it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7864031: If --views-desktop is specified from the command line, respect it. (Closed)

Created:
9 years, 3 months ago by jonathan.backer

Modified:
9 years, 3 months ago

Reviewers:
sadrul, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

If --views-desktop is specified from the command line, respect it. This allows us to pass --views-desktop=disabled from the command line. BUG=none TEST=on TOUCH_UI build, disable compositing window manager, run with --views-desktop=disabled; should have square edges on omnibar suggest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100683

Patch Set 1 : "" #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	chrome/browser/chrome_browser_main.cc	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jonathan.backer

Allows us to override --views-desktop from the command line. Good for debugging.

9 years, 3 months ago (2011-09-12 12:33:16 UTC) #1

LGTM

Expand Messages | Collapse Messages