Fix crash in extension settings when trying to enable/disable a crashed extension.

chrome/browser/resources/options/extension_list.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /**
    * Creates a new list of extensions.
    * @param {Object=} opt_propertyBag Optional properties.
    * @constructor
    * @extends {cr.ui.div}
@@ skipping 166 matching lines @@
         title.classList.add('extension-title');
         title.textContent = extension.name;
         vbox.appendChild(title);
 
         // Followed by version.
         var version = this.ownerDocument.createElement('span');
         version.classList.add('extension-version');
         version.textContent = extension.version;
         vbox.appendChild(version);
 
+        // And the additional info label (unpacked/crashed).
+        if (extension.terminated || extension.isUnpacked) {
+          var version = this.ownerDocument.createElement('span');
+          version.classList.add('extension-version');
+          version.textContent = extension.terminated ?
+              localStrings.getString('extensionSettingsCrashMessage') :
+              localStrings.getString('extensionSettingsInDevelopment');
+          vbox.appendChild(version);
+        }
+
         div = this.ownerDocument.createElement('div');
         vbox.appendChild(div);
 
         // And below that we have description (if provided).
         if (extension.description.length > 0) {
           var description = this.ownerDocument.createElement('span');
           description.classList.add('extension-description');
           description.textContent = extension.description;
           vbox.appendChild(description);
         }
@@ skipping 27 matching lines @@
         this.decorateDetailsSection_(details, extension, expanded, butterbar);
 
         // And on the right of the details we have the Enable/Enabled checkbox.
         div = this.ownerDocument.createElement('div');
         hbox.appendChild(div);
 
         var section = this.ownerDocument.createElement('section');
         section.classList.add('extension-enabling');
         div.appendChild(section);
 
-        // The Enable checkbox.
-        var input = this.ownerDocument.createElement('input');
-        input.addEventListener('click', this.handleEnable_.bind(this));
-        input.type = 'checkbox';
-        input.name = 'toggle-' + id;
-        if (!extension.mayDisable)
-          input.disabled = true;
-        if (extension.enabled)
-          input.checked = true;
-        input.id = 'toggle-' + id;
-        section.appendChild(input);
-        var label = this.ownerDocument.createElement('label');
-        label.classList.add('extension-enabling-label');
-        if (extension.enabled)
-          label.classList.add('extension-enabling-label-bold');
-        label.setAttribute('for', 'toggle-' + id);
-        label.id = 'toggle-' + id + '-label';
-        if (extension.enabled) {
-          // Enabled (with a d).
-          label.textContent =
-              localStrings.getString('extensionSettingsEnabled');
+        if (!extension.terminated) {
+          // The Enable checkbox.
+          var input = this.ownerDocument.createElement('input');
+          input.addEventListener('click', this.handleEnable_.bind(this));
+          input.type = 'checkbox';
+          input.name = 'toggle-' + id;
+          if (!extension.mayDisable)
+            input.disabled = true;
+          if (extension.enabled)
+            input.checked = true;
+          input.id = 'toggle-' + id;
+          section.appendChild(input);
+          var label = this.ownerDocument.createElement('label');
+          label.classList.add('extension-enabling-label');
+          if (extension.enabled)
+            label.classList.add('extension-enabling-label-bold');
+          label.setAttribute('for', 'toggle-' + id);
+          label.id = 'toggle-' + id + '-label';
+          if (extension.enabled) {
+            // Enabled (with a d).
+            label.textContent =
+                localStrings.getString('extensionSettingsEnabled');
+          } else {
+            // Enable (no d).
+            label.textContent =
+                localStrings.getString('extensionSettingsEnable');
+          }
+          section.appendChild(label);
+
+          if (label.offsetWidth > maxCheckboxWidth)
+            maxCheckboxWidth = label.offsetWidth;
+          if (label.offsetWidth < minCheckboxWidth)
+            minCheckboxWidth = label.offsetWidth;
         } else {
-          // Enable (no d).
-          label.textContent = localStrings.getString('extensionSettingsEnable');
+          // Extension has been terminated, show a Reload link.
+          var link = this.ownerDocument.createElement('a');
+          link.classList.add('extension-links-trailing');
+          link.id = extension.id;
+          link.textContent =
+              localStrings.getString('extensionSettingsReload');
+          link.href = '#';
+          link.addEventListener('click', this.handleReload_.bind(this));
+          section.appendChild(link);
         }
-        section.appendChild(label);
-
-        if (label.offsetWidth > maxCheckboxWidth)
-          maxCheckboxWidth = label.offsetWidth;
-        if (label.offsetWidth < minCheckboxWidth)
-          minCheckboxWidth = label.offsetWidth;
 
         // And, on the far right we have the uninstall button.
         var button = this.ownerDocument.createElement('button');
         button.classList.add('extension-delete');
         button.id = id;
         if (!extension.mayDisable)
           button.disabled = true;
         button.textContent = localStrings.getString('extensionSettingsRemove');
         button.addEventListener('click', this.handleUninstall_.bind(this));
         hbox.appendChild(button);
@@ skipping 390 matching lines @@
           ]);
         }
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });