Issue 7864029: Fix crash in extension settings when trying to enable/disable a crashed extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7864029: Fix crash in extension settings when trying to enable/disable a crashed extension. (Closed)

Created:
9 years, 3 months ago by Finnur

Modified:
9 years, 3 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix crash in extension settings when trying to enable/disable a crashed extension. Also make the padding more RTL friendly, since I'm adding one more. BUG=96096 TEST=Concise reproduction steps found within bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100894

Patch Set 1 #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -50 lines)			Patch
M	chrome/browser/resources/options/extension_list.js	View	2 chunks	+52 lines, -29 lines	0 comments	Download
M	chrome/browser/resources/options/extension_settings.css	View	8 chunks	+21 lines, -20 lines	2 comments	Download
M	chrome/browser/ui/webui/options/extension_settings_handler.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM http://codereview.chromium.org/7864029/diff/1/chrome/browser/resources/options/extension_settings.css File chrome/browser/resources/options/extension_settings.css (right): http://codereview.chromium.org/7864029/diff/1/chrome/browser/resources/options/extension_settings.css#newcode8 chrome/browser/resources/options/extension_settings.css:8: -webkit-padding-end: 10px; These changes don't look related. If ...

9 years, 3 months ago (2011-09-12 16:02:59 UTC) #2

Finnur

9 years, 3 months ago (2011-09-12 16:14:13 UTC) #3

http://codereview.chromium.org/7864029/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/extension_settings.css (right):

http://codereview.chromium.org/7864029/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/extension_settings.css:8: -webkit-padding-end:
10px;
Ah, yeah. I was planning to update the CL description but forgot. Thanks for the
reminder. I figured since I was adding another padding-right, I might as well
add an RTL friendly version of it and fix the old ones, while I was at it.

On 2011/09/12 16:02:59, Yoyo Zhou wrote:
> These changes don't look related. If you plan to include them, can you update
> the CL description?

Expand Messages | Collapse Messages