Issue 7864024: Move the implementation of Scanner::LiteralScope to scanner.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7864024: Move the implementation of Scanner::LiteralScope to scanner.cc (Closed)

Created:
9 years, 3 months ago by tfarina

Modified:
9 years, 3 months ago

Reviewers:
Lasse Reichstein, mnaganov (inactive)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@bleeding_edge

Visibility:
Public.

Move the implementation of Scanner::LiteralScope to scanner.cc It seems more appropriate as LiteralScope is declared in scanner.h R=lrn@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://code.google.com/p/v8/source/detail?r=9222

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -21 lines)			Patch
	M	src/scanner.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
	M	src/scanner-character-streams.cc	View		2 chunks	+0 lines, -21 lines	0 comments	Download

Total messages: 3 (0 generated)

mnaganov (inactive)

I believe, Lasse is more appropriate reviewer.

9 years, 3 months ago (2011-09-10 18:13:57 UTC) #2

LGTM