Fixing the bug, that caused UI to hang after unsupported device was inserted.

Fixing the bug, that caused UI to hang after unsupported device was inserted.
In the idle.h new synchronous method was added - IsWorkstationInLockedState.

BUG=chromium-os:20261
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100582

[sidor, 2011-09-10 00:21:22]

Hi,

Could you please review my code.

Thanks,
Szymon

[tonibarzic, 2011-09-10 00:37:39]

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h
File chrome/browser/idle.h (right):

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h#newcode31
chrome/browser/idle.h:31: // of check if CalculateIdleState(0, ...) callback
doesn't return
Checks if Idle state is IDLE_STATE_LOCKED.

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h#newcode33
chrome/browser/idle.h:33: bool IsWorkstationInLockedState();
I find this name to similar to IsWorkstationLocked in ide_win.cc
My suggestion is CheckIdleStateEqualsLocked(), or CheckIdleStateIsLocked()

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle_mac.mm
File chrome/browser/idle_mac.mm (right):

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle_mac.mm#n...
chrome/browser/idle_mac.mm:104: [g_screenMonitor isScreenLocked];
align with [ in the row above

[sidor, 2011-09-10 02:18:27]

Done.

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h
File chrome/browser/idle.h (right):

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h#newcode31
chrome/browser/idle.h:31: // of check if CalculateIdleState(0, ...) callback
doesn't return
On 2011/09/10 00:37:40, tonibarzic wrote:
> Checks if Idle state is IDLE_STATE_LOCKED.

Done.

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h#newcode33
chrome/browser/idle.h:33: bool IsWorkstationInLockedState();
On 2011/09/10 00:37:40, tonibarzic wrote:
> I find this name to similar to IsWorkstationLocked in ide_win.cc
> My suggestion is CheckIdleStateEqualsLocked(), or CheckIdleStateIsLocked()

Done.

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle_mac.mm
File chrome/browser/idle_mac.mm (right):

http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle_mac.mm#n...
chrome/browser/idle_mac.mm:104: [g_screenMonitor isScreenLocked];
On 2011/09/10 00:37:40, tonibarzic wrote:
> align with [ in the row above

Won't fit.

[tbarzic, 2011-09-10 02:21:16]

On 2011/09/10 02:18:27, sidor wrote:
> Done.
> 
> http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h
> File chrome/browser/idle.h (right):
> 
>
http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h#newcode31
> chrome/browser/idle.h:31: // of check if CalculateIdleState(0, ...) callback
> doesn't return
> On 2011/09/10 00:37:40, tonibarzic wrote:
> > Checks if Idle state is IDLE_STATE_LOCKED.
> 
> Done.
> 
>
http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle.h#newcode33
> chrome/browser/idle.h:33: bool IsWorkstationInLockedState();
> On 2011/09/10 00:37:40, tonibarzic wrote:
> > I find this name to similar to IsWorkstationLocked in ide_win.cc
> > My suggestion is CheckIdleStateEqualsLocked(), or CheckIdleStateIsLocked()
> 
> Done.
> 
> http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle_mac.mm
> File chrome/browser/idle_mac.mm (right):
> 
>
http://codereview.chromium.org/7864022/diff/2002/chrome/browser/idle_mac.mm#n...
> chrome/browser/idle_mac.mm:104: [g_screenMonitor isScreenLocked];
> On 2011/09/10 00:37:40, tonibarzic wrote:
> > align with [ in the row above
> 
> Won't fit.

LGTM

[commit-bot: I haz the power, 2011-09-10 07:54:53]

Change committed as 100582