Eliminate the need for code delete events in CPU profiler.

tools/codemap.js

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 61 matching lines @@
     1 << CodeMap.PAGE_ALIGNMENT;
 
 
 /**
  * Adds a dynamic (i.e. moveable and discardable) code entry.
  *
  * @param {number} start The starting address.
  * @param {CodeMap.CodeEntry} codeEntry Code entry object.
  */
 CodeMap.prototype.addCode = function(start, codeEntry) {
-  this.removeAllCoveredNodes_(this.dynamics_, start, start + codeEntry.size);
+  this.deleteAllCoveredNodes_(this.dynamics_, start, start + codeEntry.size);
   this.dynamics_.insert(start, codeEntry);
 };
 
 
 /**
  * Moves a dynamic code entry. Throws an exception if there is no dynamic
  * code entry with the specified starting address.
  *
  * @param {number} from The starting address of the entry being moved.
  * @param {number} to The destination address.
  */
 CodeMap.prototype.moveCode = function(from, to) {
   if (from === to) return;
   var removedNode = this.dynamics_.remove(from);
-  this.removeAllCoveredNodes_(this.dynamics_, to, to + removedNode.value.size);
+  this.deleteAllCoveredNodes_(this.dynamics_, to, to + removedNode.value.size);
   this.dynamics_.insert(to, removedNode.value);
 };
 
 
 /**
  * Discards a dynamic code entry. Throws an exception if there is no dynamic
  * code entry with the specified starting address.
  *
  * @param {number} start The starting address of the entry being deleted.
  */
@@ skipping 34 matching lines @@
   for (var addr = start; addr <= end;
        addr += CodeMap.PAGE_SIZE) {
     this.pages_[addr >>> CodeMap.PAGE_ALIGNMENT] = 1;
   }
 };
 
 
 /**
  * @private
  */
+CodeMap.prototype.deleteAllCoveredNodes_ = function(tree, start, end) {
+  var to_delete = [];
+  var addr = end - 1;
+  while (addr >= start) {
+    var node = tree.findGreatestLessThan(addr);
+    if (!node) break;
+    var start2 = node.key, end2 = start2 + node.value.size;
+    if (start2 < end && start < end2) to_delete.push(start2);
+    addr = start2 - 1;
+  }
+  for (var i = 0, l = to_delete.length; i < l; ++i) tree.remove(to_delete[i]);
+};
+
+
+/**
+ * @private
+ */
 CodeMap.prototype.isAddressBelongsTo_ = function(addr, node) {
   return addr >= node.key && addr < (node.key + node.value.size);
 };
 
 
-/**
- * @private
- */
-CodeMap.prototype.findAllCoveredNodes_ = function(tree, start, end) {
-  var result = [];
-  var addr = end - 1;
-  while (addr >= start) {
-    var node = tree.findGreatestLessThan(addr);
-    if (!node) break;
-    var start2 = node.key, end2 = node.key + node.value.size;
-    if (start2 < end && start < end2) {
-      // Node overlaps with the interval given
-      result.push(node);
-    }
-    addr = node.key - 1;
-  }
-  return result;
-};
-
-
 /**
  * @private
  */
 CodeMap.prototype.findInTree_ = function(tree, addr) {
   var node = tree.findGreatestLessThan(addr);
   return node && this.isAddressBelongsTo_(addr, node) ? node.value : null;
 };
 
 
 /**
@@ skipping 63 matching lines @@
 
 
 /**
  * Returns an array of all libraries entries.
  */
 CodeMap.prototype.getAllLibrariesEntries = function() {
   return this.libraries_.exportValues();
 };
 
 
-CodeMap.prototype.removeAllCoveredNodes_ = function(tree, start, end) {
-  var covered = this.findAllCoveredNodes_(tree, start, end);
-  for (var i = 0, l = covered.length; i < l; ++i) {
-    tree.remove(covered[i].key);
-  }
-};
-
-
 /**
  * Creates a code entry object.
  *
  * @param {number} size Code entry size in bytes.
  * @param {string} opt_name Code entry name.
  * @constructor
  */
 CodeMap.CodeEntry = function(size, opt_name) {
   this.size = size;
   this.name = opt_name || '';
@@ skipping 17 matching lines @@
 
 
 CodeMap.NameGenerator.prototype.getName = function(name) {
   if (!(name in this.knownNames_)) {
     this.knownNames_[name] = 0;
     return name;
   }
   var count = ++this.knownNames_[name];
   return name + ' {' + count + '}';
 };