Chromium Code Reviews| Index: chrome/browser/browser_about_handler.cc |
| diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc |
| index aeb75e542eab04742b0102a114afee478e80104a..a53b0c310023b0919c7e89b36e12170339f3ced8 100644 |
| --- a/chrome/browser/browser_about_handler.cc |
| +++ b/chrome/browser/browser_about_handler.cc |
| @@ -60,14 +60,11 @@ |
| #include "net/base/net_util.h" |
| #include "ui/base/l10n/l10n_util.h" |
| #include "ui/base/resource/resource_bundle.h" |
| +#include "v8/include/v8.h" |
| #include "webkit/glue/webkit_glue.h" |
| #include "webkit/plugins/npapi/plugin_list.h" |
| #include "webkit/plugins/webplugininfo.h" |
| -#ifdef CHROME_V8 |
| -#include "v8/include/v8.h" |
| -#endif |
| - |
| #if defined(OS_WIN) |
| #include "chrome/browser/enumerate_modules_model_win.h" |
| #elif defined(OS_CHROMEOS) |
| @@ -1106,13 +1103,8 @@ std::string AboutVersionStrings(DictionaryValue* localized_strings, |
| chrome::VersionInfo version_info; |
| std::string webkit_version = webkit_glue::GetWebKitVersion(); |
| -#ifdef CHROME_V8 |
| std::string js_version(v8::V8::GetVersion()); |
|
tfarina
2011/09/09 22:01:40
you can call v8::V8::GetVersion() directly at line
Mihai Parparita -not on Chrome
2011/09/09 22:36:32
Done.
|
| std::string js_engine = "V8"; |
|
tfarina
2011/09/09 22:01:40
same thing here.
Mihai Parparita -not on Chrome
2011/09/09 22:36:32
Done.
|
| -#else |
| - std::string js_version = webkit_version; |
| - std::string js_engine = "JavaScriptCore"; |
| -#endif |
| localized_strings->SetString("name", |
| l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)); |