Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: trychange.py

Issue 7864007: Use check_call(), not check_output() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 50e32b859b6418aeae46d474004e04d12c24c2d4..a40b6e12cf31a6bda5373edd0c57a7993dd2eac6 100755
--- a/trychange.py
+++ b/trychange.py
@@ -401,10 +401,9 @@ def _SendChangeSVN(options):
if scm.SVN.AssertVersion("1.5")[0]:
command.append('--no-ignore')
- subprocess2.check_output(
- command, stdout=subprocess2.PIPE, stderr=subprocess2.STDOUT)
+ subprocess2.check_call(command)
except subprocess2.CalledProcessError, e:
- raise NoTryServerAccess(' '.join(e.cmd) + '\nOuput:\n' + e.stdout)
+ raise NoTryServerAccess(str(e))
finally:
temp_file.close()
shutil.rmtree(temp_dir, True)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698