Don't leak SSPILibraryDefault objects

Don't leak SSPILibraryDefault objects

BUG=74413
TEST=Dr. Memory.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100930

[asanka, 2011-09-09 18:28:32]

For review.

[cbentzel, 2011-09-09 18:37:43]

This should be accompanied with the removal of the suppression.

You may also want to comment that the HttpAuthHandlerFactory needs to live
longer than the HttpAuthHandler. This is a requirement for all handlers, so it
may be documented in the base classes - if so, it doesn't need one here.

Were you able to get the leak reported locally?

[asanka, 2011-09-09 21:10:17]

I removed the suppression.

Regarding the lifetime issue, HttpAuthHandlerFactory already has a comment to
that effect, as you noted:

// The HttpAuthHandlerFactory object _must_ outlive any of the HttpAuthHandler
// objects that it creates.

[asanka, 2011-09-09 21:10:57]

And I've so far been unsuccessful in reproducing the error using Dr. Memory.

[cbentzel, 2011-09-09 21:23:18]

LGTM

As you know, I was unable to repro this on my Windows7 machine as well, despite
the fairly obvious leak. I modified the gtest_exclude's as well to ensure that
it ran.

[commit-bot: I haz the power, 2011-09-13 17:36:33]

Change committed as 100930