Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 7862036: Share Maps for ElementsKind transitions (Closed)

Created:
9 years, 3 months ago by danno
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Share Maps for ElementsKind transitions Support sharing maps after an changing an object's ElementsKind for element kinds other then external elements. R=svenpanne@chromium.org BUG=none TEST=external-arrays.js Committed: http://code.google.com/p/v8/source/detail?r=9304

Patch Set 1 #

Patch Set 2 : fix performance regression #

Patch Set 3 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -122 lines) Patch
M src/api.cc View 1 chunk +6 lines, -16 lines 0 comments Download
M src/factory.h View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +3 lines, -15 lines 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +6 lines, -21 lines 0 comments Download
M src/objects.cc View 1 2 7 chunks +27 lines, -12 lines 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +1 line, -40 lines 0 comments Download
M src/objects-printer.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 2 2 chunks +9 lines, -5 lines 0 comments Download
M src/v8-counters.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
lgtm
9 years, 3 months ago (2011-09-13 08:10:32 UTC) #1
danno
Jakob, please review the changes in hydrogen.cc
9 years, 3 months ago (2011-09-13 11:40:16 UTC) #2
Jakob Kummerow
9 years, 3 months ago (2011-09-13 12:07:49 UTC) #3
hydrogen.cc LGTM.

Powered by Google App Engine
This is Rietveld 408576698