Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 7862032: Reapply "Clean up Context::Lookup and its uses." (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Reapply "Clean up Context::Lookup and its uses." With a fix for a context lookup bug in the original change. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -246 lines) Patch
M src/contexts.h View 2 chunks +14 lines, -24 lines 0 comments Download
M src/contexts.cc View 3 chunks +46 lines, -54 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 14 chunks +122 lines, -167 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
A last minute untested simplification turned a runtime search for the declaration context into an ...
9 years, 3 months ago (2011-09-12 10:47:43 UTC) #1
fschneider
9 years, 3 months ago (2011-09-12 11:12:54 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698