Issue 7862032: Reapply "Clean up Context::Lookup and its uses."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7862032: Reapply "Clean up Context::Lookup and its uses." (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 3 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reapply "Clean up Context::Lookup and its uses." With a fix for a context lookup bug in the original change. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9241

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+182 lines, -246 lines)			Patch
M	src/contexts.h	View	2 chunks	+14 lines, -24 lines	0 comments	Download
M	src/contexts.cc	View	3 chunks	+46 lines, -54 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	14 chunks	+122 lines, -167 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Chromium)

A last minute untested simplification turned a runtime search for the declaration context into an ...

9 years, 3 months ago (2011-09-12 10:47:43 UTC) #1

LGTM.