Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: chrome/test/test_html_dialog_observer.h

Issue 7861024: Adds testing infrastructure to web_ui_browsertest to support testing HtmlDialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move class implementation to test/data dir and use continueTest for async tests. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/test_html_dialog_observer.h
diff --git a/chrome/test/test_html_dialog_observer.h b/chrome/test/test_html_dialog_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..55663e66244e874ea94e5b6a6a46cd67a9711aef
--- /dev/null
+++ b/chrome/test/test_html_dialog_observer.h
@@ -0,0 +1,41 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_TEST_TEST_HTML_DIALOG_OBSERVER_H_
Paweł Hajdan Jr. 2011/09/15 22:11:31 Do not add this directly under test. Use test/base
flackr 2011/09/16 15:44:00 Done.
+#define CHROME_TEST_TEST_HTML_DIALOG_OBSERVER_H_
+#pragma once
+
+#include "content/common/notification_observer.h"
+#include "content/common/notification_registrar.h"
+
+class WebUI;
+
+// For browser_tests, which run on the UI thread, run a second message
+// MessageLoop to detect HtmlDialog creation and quit when the constructed
+// WebUI instance is captured and ready.
+class TestHtmlDialogObserver : public NotificationObserver {
+ public:
+ // Create and register a new TestHtmlDialogObserver.
+ TestHtmlDialogObserver();
+ virtual ~TestHtmlDialogObserver();
+
+ // Waits for an HtmlDialog to be created. The WebUI instance is captured
+ // and the method returns it when the navigation on the dialog is complete.
+ WebUI* GetWebUI();
+
+ private:
+ // NotificationObserver:
+ virtual void Observe(int type, const NotificationSource& source,
+ const NotificationDetails& details);
+
+ NotificationRegistrar registrar_;
+
+ WebUI* web_ui_;
+ bool done_;
+ bool running_;
+
+ DISALLOW_COPY_AND_ASSIGN(TestHtmlDialogObserver);
+};
+
+#endif // CHROME_TEST_TEST_HTML_DIALOG_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698