chrome/browser/ui/webui/html_dialog_ui.cc - Issue 7861024: Adds testing infrastructure to web_ui_browsertest to support testing HtmlDialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/html_dialog_ui.cc

Issue 7861024: Adds testing infrastructure to web_ui_browsertest to support testing HtmlDialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move observing html dialog to separate class and test declarations to JS. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/certificate_viewer_ui_browsertest.cc ('K') | « chrome/browser/ui/webui/certificate_viewer_ui_browsertest.cc ('k') | chrome/browser/ui/webui/web_ui_browsertest.h » ('j') | chrome/test/data/webui/certificate_viewer_dialog_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/html_dialog_ui.cc

diff --git a/chrome/browser/ui/webui/html_dialog_ui.cc b/chrome/browser/ui/webui/html_dialog_ui.cc

index fd3341a4bbe187646a511a3a239a7d6a266e4bbf..511c8e4300fe939b80da4520f4a611bd23472874 100644

--- a/chrome/browser/ui/webui/html_dialog_ui.cc

+++ b/chrome/browser/ui/webui/html_dialog_ui.cc

@@ -7,9 +7,11 @@

#include "base/callback.h"

#include "base/lazy_instance.h"

#include "base/values.h"

+#include "chrome/common/chrome_notification_types.h"

#include "content/browser/renderer_host/render_view_host.h"

#include "content/browser/tab_contents/tab_contents.h"

#include "content/common/bindings_policy.h"

+#include "content/common/notification_service.h"

static base::LazyInstance<PropertyAccessor<HtmlDialogUIDelegate*> >

g_html_dialog_ui_property_accessor(base::LINKER_INITIALIZED);

@@ -60,6 +62,11 @@ void HtmlDialogUI::RenderViewCreated(RenderViewHost* render_view_host) {

(*it)->Attach(this);

AddMessageHandler(*it);

}

+ NotificationService::current()->Notify(

+ chrome::NOTIFICATION_HTML_DIALOG_SHOWN,

+ Source<HtmlDialogUI>(this),

+ NotificationService::NoDetails());

}

void HtmlDialogUI::OnDialogClosed(const ListValue* args) {