chrome/common/chrome_notification_types.h - Issue 7861024: Adds testing infrastructure to web_ui_browsertest to support testing HtmlDialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_notification_types.h

Issue 7861024: Adds testing infrastructure to web_ui_browsertest to support testing HtmlDialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add description of what triggers notifications and why it's not a race condition. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/web_ui_browsertest.h ('K') | « chrome/chrome_tests.gypi ('k') | chrome/test/base/test_html_dialog_observer.h » ('j') | chrome/test/base/test_html_dialog_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/chrome_notification_types.h

diff --git a/chrome/common/chrome_notification_types.h b/chrome/common/chrome_notification_types.h

index ca730fcccb75c78c06da937430fc9cb83aa2d851..367cbd0cf2eff89bef00528c9e8f105d162c09de 100644

--- a/chrome/common/chrome_notification_types.h

+++ b/chrome/common/chrome_notification_types.h

@@ -71,6 +71,9 @@ enum NotificationType {

// traversal. The source is the browser, there are no details.

NOTIFICATION_FOCUS_RETURNED_TO_BROWSER,

+ // Sent after an HtmlDialog dialog has been shown. The source is the dialog.

+ NOTIFICATION_HTML_DIALOG_SHOWN,

// Application-modal dialogs -----------------------------------------------

// Sent after an application-modal dialog has been shown. The source