Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3351)

Unified Diff: chrome/browser/sync/sessions/test_util.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't treat MIGRATION_DONE as an error Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/test_util.cc
diff --git a/chrome/browser/sync/sessions/test_util.cc b/chrome/browser/sync/sessions/test_util.cc
index 65d307b7387adddf3251381faa0c0a43a029787d..c01f02fd7b1ed5ea34fb0e500d012f6b3d1cc701 100644
--- a/chrome/browser/sync/sessions/test_util.cc
+++ b/chrome/browser/sync/sessions/test_util.cc
@@ -24,13 +24,9 @@ void SimulateDownloadUpdatesFailed(sessions::SyncSession* session,
void SimulateCommitFailed(sessions::SyncSession* session,
SyncerStep begin, SyncerStep end) {
- // Note that a non-zero number of unsynced handles once a session has
- // completed implies that the Syncer was unable to make forward progress
- // during a commit, indicating an error occurred.
- // See implementation of SyncSession::HasMoreToSync.
- std::vector<int64> handles;
- handles.push_back(1);
- session->status_controller()->set_unsynced_handles(handles);
+ // This indicates an error, not necessarily a commit error. The effect is
+ // the same.
+ session->status_controller()->increment_num_consecutive_errors();
}
void SimulateSuccess(sessions::SyncSession* session,
« chrome/browser/sync/sessions/sync_session.cc ('K') | « chrome/browser/sync/sessions/sync_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698