chrome/browser/sync/engine/syncer_proto_util.cc - Issue 7861013: Fix the false-positive detection of commit errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/syncer_proto_util.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't treat MIGRATION_DONE as an error Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/engine/syncer_proto_util.cc

diff --git a/chrome/browser/sync/engine/syncer_proto_util.cc b/chrome/browser/sync/engine/syncer_proto_util.cc

index 26eed05cb70a36c211394a58ce8269ff6ed074a5..5a409fe326c2c28cde85fb884c77e5080a9b011c 100644

--- a/chrome/browser/sync/engine/syncer_proto_util.cc

+++ b/chrome/browser/sync/engine/syncer_proto_util.cc

@@ -340,7 +340,7 @@ bool SyncerProtoUtil::PostClientToServerMessage(

return false;

case browser_sync::MIGRATION_DONE:

HandleMigrationDoneResponse(response, session);

- return false;

+ return true;

case browser_sync::CLEAR_PENDING:

case browser_sync::NOT_MY_BIRTHDAY:

return false;