Fix the false-positive detection of commit errors

chrome/browser/sync/sessions/sync_session.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A class representing an attempt to synchronize the local syncable data
 // store with a sync server. A SyncSession instance is passed as a stateful
 // bundle to and from various SyncerCommands with the goal of converging the
 // client view of data with that of the server. The commands twiddle with
 // session status in response to events and hiccups along the way, set and
 // query session progress with regards to conflict resolution and applying
@@ skipping 90 matching lines @@
               const std::vector<ModelSafeWorker*>& workers);
   ~SyncSession();
 
   // Builds a thread-safe and read-only copy of the current session state.
   SyncSessionSnapshot TakeSnapshot() const;
 
   // Returns true if this session contains data that should go through the sync
   // engine again.
   bool HasMoreToSync() const;
 
+  // Returns true if this session experienced an error that prevented it from
+  // making progress.
+  bool WasUnableToMakeProgress() const;

[tim (not reviewing), 2011/09/20 20:32:12]

FailedToMake[Forward]Progress?

+
   // Collects all state pertaining to how and why |s| originated and unions it
   // with corresponding state in |this|, leaving |s| unchanged.  Allows |this|
   // to take on the responsibilities |s| had (e.g. certain data types) in the
   // next SyncShare operation using |this|, rather than needed two separate
   // sessions.
   void Coalesce(const SyncSession& session);
 
   // Compares the routing_info_, workers and payload map with the passed in
   // session. Purges types from the above 3 which are not in session. Useful
   // to update the sync session when the user has disabled some types from
@@ skipping 76 matching lines @@
 
  private:
   SyncSession* session_;
   DISALLOW_COPY_AND_ASSIGN(ScopedSetSessionWriteTransaction);
 };
 
 }  // namespace sessions
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_SESSIONS_SYNC_SESSION_H_