Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: trychange.py

Issue 7860047: Fix check_output usage in trychange.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 54a02d992ba036a305529b8e6bc87f1db6de74df..50e32b859b6418aeae46d474004e04d12c24c2d4 100755
--- a/trychange.py
+++ b/trychange.py
@@ -401,12 +401,10 @@ def _SendChangeSVN(options):
if scm.SVN.AssertVersion("1.5")[0]:
command.append('--no-ignore')
- subprocess2.check_output(command, stdout=subprocess2.VOID)
+ subprocess2.check_output(
+ command, stdout=subprocess2.PIPE, stderr=subprocess2.STDOUT)
except subprocess2.CalledProcessError, e:
- out = e.stdout
- if e.stderr:
- out += e.stderr
- raise NoTryServerAccess(' '.join(e.command) + '\nOuput:\n' + out)
+ raise NoTryServerAccess(' '.join(e.cmd) + '\nOuput:\n' + e.stdout)
finally:
temp_file.close()
shutil.rmtree(temp_dir, True)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698