Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 7860039: Re-land http://codereview.chromium.org/7831056/ and http://codereview.chromium.org/7833042/ . (Closed)

Created:
9 years, 3 months ago by erikwright (departed)
Modified:
9 years, 3 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, kkania, erikwright (departed), dpranke+watch-content_chromium.org, jam, Randy Smith (Not in Mondays), joi+watch-content_chromium.org, wtc, Paweł Hajdan Jr., darin-cc_chromium.org, rkn, pam+watch_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Re-land http://codereview.chromium.org/7831056/ and http://codereview.chromium.org/7833042/ . Finalize a CL originally by departed intern ycxiao@ that detaches the loading of cookies from the IO thread. They are now loaded on the DB thread. Cookie operations received in the meantime are queued and executed, on the IO thread, in the order they were received, when loading completes. A few straggler clients are updated to use the asynchronous CookieStore/CookieMonster API as part of this CL, as the synchronous API is removed. This entire CL has been previously reviewed by the appropriate owners, however an error was made during the submit. BUG=68657 TEST=net_unittests / DeferredCookieTaskTest.* and CookieMonsterTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1796 lines, -692 lines) Patch
M chrome/browser/automation/automation_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_remover.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/fast_shutdown_uitest.cc View 7 chunks +25 lines, -14 lines 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store.h View 1 chunk +10 lines, -6 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store.cc View 8 chunks +69 lines, -19 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc View 5 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/base/cookie_monster.h View 14 chunks +110 lines, -53 lines 0 comments Download
M net/base/cookie_monster.cc View 26 chunks +585 lines, -121 lines 0 comments Download
M net/base/cookie_monster_perftest.cc View 9 chunks +140 lines, -61 lines 0 comments Download
M net/base/cookie_monster_store_test.h View 5 chunks +23 lines, -9 lines 0 comments Download
M net/base/cookie_monster_store_test.cc View 4 chunks +27 lines, -15 lines 0 comments Download
M net/base/cookie_monster_unittest.cc View 67 chunks +711 lines, -242 lines 0 comments Download
M net/base/cookie_store.h View 4 chunks +9 lines, -43 lines 0 comments Download
M net/base/cookie_store.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M net/base/cookie_store_test_helpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/cookie_store_test_helpers.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_http_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 3 chunks +13 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 4 chunks +12 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698