Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: scm.py

Issue 7860038: Some callers expect e.stderr to be filled on exception (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scm.py
diff --git a/scm.py b/scm.py
index 9eab39aeccd7639f37cfcbc7bc8d8e357c97a92c..80e5fc4a592ce57bbec6aa2c91e334990734c2d1 100644
--- a/scm.py
+++ b/scm.py
@@ -89,7 +89,7 @@ class GIT(object):
@staticmethod
def Capture(args, **kwargs):
return subprocess2.check_output(
- ['git'] + args, stderr=subprocess2.VOID, **kwargs)
+ ['git'] + args, stderr=subprocess2.PIPE, **kwargs)
@staticmethod
def CaptureStatus(files, upstream_branch=None):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698