Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: src/smart-pointer.h

Issue 7860011: Rename SmartPointer to SmartArrayPointer. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge
Patch Set: rebase it again to get more fixes Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/smart-array-pointer.h ('k') | src/string-stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/smart-pointer.h
diff --git a/src/smart-pointer.h b/src/smart-pointer.h
deleted file mode 100644
index a3e930d81a0c1c58c42a0621cd059deee2cfb549..0000000000000000000000000000000000000000
--- a/src/smart-pointer.h
+++ /dev/null
@@ -1,100 +0,0 @@
-// Copyright 2008 the V8 project authors. All rights reserved.
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-// * Redistributions of source code must retain the above copyright
-// notice, this list of conditions and the following disclaimer.
-// * Redistributions in binary form must reproduce the above
-// copyright notice, this list of conditions and the following
-// disclaimer in the documentation and/or other materials provided
-// with the distribution.
-// * Neither the name of Google Inc. nor the names of its
-// contributors may be used to endorse or promote products derived
-// from this software without specific prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-#ifndef V8_SMART_POINTER_H_
-#define V8_SMART_POINTER_H_
-
-namespace v8 {
-namespace internal {
-
-
-// A 'scoped array pointer' that calls DeleteArray on its pointer when the
-// destructor is called.
-template<typename T>
-class SmartPointer {
- public:
- // Default constructor. Constructs an empty scoped pointer.
- inline SmartPointer() : p_(NULL) {}
-
- // Constructs a scoped pointer from a plain one.
- explicit inline SmartPointer(T* ptr) : p_(ptr) {}
-
- // Copy constructor removes the pointer from the original to avoid double
- // freeing.
- inline SmartPointer(const SmartPointer<T>& rhs) : p_(rhs.p_) {
- const_cast<SmartPointer<T>&>(rhs).p_ = NULL;
- }
-
- // When the destructor of the scoped pointer is executed the plain pointer
- // is deleted using DeleteArray. This implies that you must allocate with
- // NewArray.
- inline ~SmartPointer() { if (p_) DeleteArray(p_); }
-
- inline T* operator->() const { return p_; }
-
- // You can get the underlying pointer out with the * operator.
- inline T* operator*() { return p_; }
-
- // You can use [n] to index as if it was a plain pointer
- inline T& operator[](size_t i) {
- return p_[i];
- }
-
- // We don't have implicit conversion to a T* since that hinders migration:
- // You would not be able to change a method from returning a T* to
- // returning an SmartPointer<T> and then get errors wherever it is used.
-
-
- // If you want to take out the plain pointer and don't want it automatically
- // deleted then call Detach(). Afterwards, the smart pointer is empty
- // (NULL).
- inline T* Detach() {
- T* temp = p_;
- p_ = NULL;
- return temp;
- }
-
- // Assignment requires an empty (NULL) SmartPointer as the receiver. Like
- // the copy constructor it removes the pointer in the original to avoid
- // double freeing.
- inline SmartPointer& operator=(const SmartPointer<T>& rhs) {
- ASSERT(is_empty());
- T* tmp = rhs.p_; // swap to handle self-assignment
- const_cast<SmartPointer<T>&>(rhs).p_ = NULL;
- p_ = tmp;
- return *this;
- }
-
- inline bool is_empty() { return p_ == NULL; }
-
- private:
- T* p_;
-};
-
-} } // namespace v8::internal
-
-#endif // V8_SMART_POINTER_H_
« no previous file with comments | « src/smart-array-pointer.h ('k') | src/string-stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698