Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 7860011: Rename SmartPointer to SmartArrayPointer. (Closed)

Created:
9 years, 3 months ago by tfarina
Modified:
9 years, 3 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

Rename SmartPointer to SmartArrayPointer. As pointed out in: http://codereview.chromium.org/7754007/#msg5 "SmartPointer should have been named SmartArrayPointer as it expects an input allocated using new[] and deallocates it using delete[]. Using it as a simple scoped pointer for a single object is incorrect." R=mnaganov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=9215

Patch Set 1 #

Patch Set 2 : 80 col #

Patch Set 3 : rebase to master to get the fixes from d8 #

Patch Set 4 : rebase it again to get more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -250 lines) Patch
M src/arm/lithium-arm.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/d8.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/d8.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/d8-debug.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/d8-debug.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/d8-readline.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/debug-agent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug-agent.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flags.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gdb-jit.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/liveobjectlist.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M src/log.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M src/log-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.h View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/objects.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M src/objects.cc View 1 5 chunks +14 lines, -14 lines 0 comments Download
M src/parser.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/prettyprinter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/smart-array-pointer.h View 6 chunks +14 lines, -14 lines 0 comments Download
D src/smart-pointer.h View 1 chunk +0 lines, -100 lines 0 comments Download
M src/string-stream.h View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-func-name-inference.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-regexp.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-reloc-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Now tracking the bleeding_edge.
9 years, 3 months ago (2011-09-08 22:41:40 UTC) #1
mnaganov (inactive)
9 years, 3 months ago (2011-09-09 21:21:08 UTC) #2
On 2011/09/08 22:41:40, tfarina wrote:
> Now tracking the bleeding_edge.

Cool. LGTM. I'll land it.

Powered by Google App Engine
This is Rietveld 408576698