Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: git_try.py

Issue 7860004: GIT.Capture doesn't throw gclient_utils.Error anymore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_try.py
diff --git a/git_try.py b/git_try.py
index f3f2332c9a222ddde67d4a86f312b0ca4188ae15..06aaa6eb5f2acefd3a4abb1d44737a0d95ef784a 100755
--- a/git_try.py
+++ b/git_try.py
@@ -9,8 +9,8 @@ import sys
import breakpad # pylint: disable=W0611
-import gclient_utils
from scm import GIT
+import subprocess2
import third_party.upload
import trychange
@@ -19,7 +19,7 @@ def GetRietveldIssueNumber():
try:
return GIT.Capture(
['config', 'branch.%s.rietveldissue' % GIT.GetBranch(None)])
- except gclient_utils.Error:
+ except subprocess2.CalledProcessError:
return None
@@ -27,14 +27,14 @@ def GetRietveldPatchsetNumber():
try:
return GIT.Capture(
['config', 'branch.%s.rietveldpatchset' % GIT.GetBranch(None)])
- except gclient_utils.Error:
+ except subprocess2.CalledProcessError:
return None
def GetRietveldServerUrl():
try:
return GIT.Capture(['config', 'rietveld.server']).strip()
- except gclient_utils.Error:
+ except subprocess2.CalledProcessError:
return None
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698