Issue 7859007: Reland 100233 PrintPreview: Added code to identify the printer default duplex value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7859007: Reland 100233 PrintPreview: Added code to identify the printer default duplex value. (Closed)

Created:
9 years, 3 months ago by kmadhusu

Modified:
9 years, 3 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland 100233 PrintPreview: Added code to identify the printer default duplex value. Added code to identify the printer default duplex value. If we are unable to get the default value, hide the two sided option in the preview tab. BUG=89204 TEST=Please refer to bug description. Original Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=100233 Try bot results are in http://codereview.chromium.org/7817013/ patch set 13. Original Review URL: http://codereview.chromium.org/7817013/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100256

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -27 lines)			Patch
M	chrome/browser/printing/print_dialog_gtk.cc	View	1	1 chunk	+17 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/print_preview/copies_settings.js	View		4 chunks	+36 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.cc	View		6 chunks	+26 lines, -5 lines	0 comments	Download
M	chrome/test/data/webui/print_preview.js	View		5 chunks	+54 lines, -0 lines	0 comments	Download
M	printing/print_job_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	printing/printing_context_mac.mm	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	printing/printing_context_win.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

kmadhusu

Fixed linux compile errors. Patch set 1 contains the original commit CL. Patch set 2 ...

9 years, 3 months ago (2011-09-08 20:46:00 UTC) #1

LGTM