Added ability to set ChromeDownloadManagerDelegate for testing.

chrome/test/base/testing_profile.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/testing_profile.h"
 
 #include "build/build_config.h"
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
@@ skipping 768 matching lines @@
 prerender::PrerenderManager* TestingProfile::GetPrerenderManager() {
   if (!prerender::PrerenderManager::IsPrerenderingPossible())
     return NULL;
   if (!prerender_manager_.get()) {
     prerender_manager_.reset(new prerender::PrerenderManager(
         this, g_browser_process->prerender_tracker()));
   }
   return prerender_manager_.get();
 }
 
+void TestingProfile::SetDownloadManagerDelegate(
+    ChromeDownloadManagerDelegate* delegate) {

[Paweł Hajdan Jr., 2011/09/09 22:11:54]

Why empty? This is very surprising.

[Randy Smith (Not in Mondays), 2011/09/09 23:45:14]

Maybe there's something I'm missing?  The implementation of
TestingProfile::GetDownloadManager() just returns null, and I didn't see any
machinery for dealing with DownloadManagerDelegate's within it.  How do you
think I should implement this routine, given the rest of the profile
implementation?  DCHECK?

[benjhayden, 2011/09/12 16:32:25]

Maybe just a comment?

[Randy Smith (Not in Mondays), 2011/09/12 17:52:58]

Waiting on Pawel and will be guided by him.

[Paweł Hajdan Jr., 2011/09/12 20:06:44]

Not enough. I want to save people time with a debugger (they have to get to that
comment somehow).

Either DCHECK or NOTIMPLEMENTED, whatever you prefer.

[Randy Smith (Not in Mondays), 2011/09/13 03:13:18]

Done.

[jam, 2011/09/13 17:18:03]

given that GetDownloadManager above doesn't dcheck or has a NOTIMPLEMENTED, it
doesn't seem appropriate to add one here.

+}
+
 PrefService* TestingProfile::GetOffTheRecordPrefs() {
   return NULL;
 }
 
 quota::SpecialStoragePolicy* TestingProfile::GetSpecialStoragePolicy() {
   return GetExtensionSpecialStoragePolicy();
 }
 
 void TestingProfile::DestroyWebDataService() {
   if (!web_data_service_.get())
     return;
 
   web_data_service_->Shutdown();
 }