Issue 7858031: Don't allow seal or element property definition on external arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7858031: Don't allow seal or element property definition on external arrays. (Closed)

Created:
9 years, 3 months ago by danno

Modified:
9 years, 3 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Don't allow seal or element property re-definition on external arrays. R=ricow@chromium.org BUG=95920 TEST=test/mjsunit/regress/regress-95920.js Committed: http://code.google.com/p/v8/source/detail?r=9213

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 3

Patch Set 3 : review feedback #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -0 lines)			Patch
M	src/messages.js	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-95920.js	View	1 2	1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

9 years, 3 months ago (2011-09-09 13:40:58 UTC) #2

LGTM, what about calls from freeze and preventextension, the error message seems
wrong in this case. In addition, we should have test cases for them as well.

http://codereview.chromium.org/7858031/diff/1001/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-95920.js (right):

http://codereview.chromium.org/7858031/diff/1001/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-95920.js:33: [0].every(function(){ Object.seal((new
Int8Array(42))); });
assertThrows?

http://codereview.chromium.org/7858031/diff/1001/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-95920.js:34: assertTrue(false); // Should be
unreachable
assertUnreachable?

http://codereview.chromium.org/7858031/diff/1001/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-95920.js:41: defineProperty(new Int8Array(42), "1",
{ writable: false, value: "1" });
same as above

Expand Messages | Collapse Messages