Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 7858022: Another attempt to fix crash in clock menu button. (Closed)

Created:
9 years, 3 months ago by zel
Modified:
9 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org
Visibility:
Public.

Description

Another attempt to fix crash in clock menu button. BUG=chromium-os:20171 TEST=no test crashes in chromeos::ClockMenuButton::UpdateText() Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100357

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zel
9 years, 3 months ago (2011-09-09 02:55:05 UTC) #1
xiyuan
LGTM
9 years, 3 months ago (2011-09-09 02:55:11 UTC) #2
xiyuan
9 years, 3 months ago (2011-09-09 03:07:04 UTC) #3
still LGTM

Powered by Google App Engine
This is Rietveld 408576698