git_cl.py - Issue 7858008: git cl assumes no shell is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 7858008: git cl assumes no shell is used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index b910a6b080f75e25ce32692d2a3707bb0c8b3454..ebb39c1ac2ffec5c28e0670aab28853ac1ec1a81 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -55,7 +55,7 @@ def DieWithError(message):

def RunCommand(args, error_ok=False, error_message=None, **kwargs):

try:

- return subprocess2.check_output(args, **kwargs)

+ return subprocess2.check_output(args, shell=False, **kwargs)

except subprocess2.CalledProcessError, e:

if not error_ok:

DieWithError(

« no previous file with comments | « no previous file | no next file » | no next file with comments »