Issue 7857036: Fix use-after-free of command line data on Linux/CrOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7857036: Fix use-after-free of command line data on Linux/CrOS (Closed)

Created:
9 years, 3 months ago by James Cook

Modified:
9 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix use-after-free of command line data on Linux/CrOS Typo in content_main.cc RunZygote was using an old pointer to the command line data. BUG=95620 TEST=Address sanitizer no longer shows use-after-free in browser_tests RenderProcessHostTest.ProcessOverflow Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100430

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/app/content_main.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Cook

John, PTAL. This was introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=99452 - it's a typo where the call to ...

9 years, 3 months ago (2011-09-09 16:43:40 UTC) #1

jam

lgtm, thanks http://codereview.chromium.org/7857036/diff/1/content/app/content_main.cc File content/app/content_main.cc (right): http://codereview.chromium.org/7857036/diff/1/content/app/content_main.cc#newcode300 content/app/content_main.cc:300: } accident?

9 years, 3 months ago (2011-09-09 16:49:39 UTC) #2

James Cook

9 years, 3 months ago (2011-09-09 16:51:07 UTC) #3

http://codereview.chromium.org/7857036/diff/1/content/app/content_main.cc
File content/app/content_main.cc (right):

http://codereview.chromium.org/7857036/diff/1/content/app/content_main.cc#new...
content/app/content_main.cc:300: }
On 2011/09/09 16:49:40, John Abd-El-Malek wrote:
> accident?

Yup, thanks.

Expand Messages | Collapse Messages