Issue 7857006: Make the rietveld client code ignore file status more often.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7857006: Make the rietveld client code ignore file status more often. (Closed)

Created:
9 years, 3 months ago by M-A Ruel

Modified:
9 years, 3 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel, marcvs

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Make the rietveld client code ignore file status more often. It's proved to be unreliable. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100236

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -40 lines)			Patch
	M	rietveld.py	View	1	1 chunk	+34 lines, -38 lines	0 comments	Download
	M	tests/rietveld_test.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM. http://codereview.chromium.org/7857006/diff/1/rietveld.py File rietveld.py (right): http://codereview.chromium.org/7857006/diff/1/rietveld.py#newcode169 rietveld.py:169: Nit: Delete line?

9 years, 3 months ago (2011-09-08 20:30:36 UTC) #2

Change committed as 100236

Expand Messages | Collapse Messages